Make compatible with enzyme v3 #196
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
requested changes
Sep 19, 2017
| const root = getRoot(wrapper) | ||
| const instance = root.instance() | ||
| const fn = instance && instance.constructor | ||
| const name = fn ? fn.displayName || fn.name : root.name(); |
There was a problem hiding this comment.
sadly i think this line needs to have its semicolon removed
There was a problem hiding this comment.
@ljharb when will the PR be merged so we can get this resolved?
|
@jugglinmike, any idea on these cheerio test failures and how to fix them? |
Merged
|
@lelandrichardson Any chance you could kill that semi colon to get this merged? 😄 |
|
@cameronroe i'd be happy to, but that's not what's limiting this PR. All of the cheerio tests are failing. |
|
@lelandrichardson Which build are you looking at? https://travis-ci.org/producthunt/chai-enzyme/jobs/276724493#L984 |
|
Closing in favour of #198 which is in a near finished state. Thanks for your contribution @lelandrichardson |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @ayrton
This PR updates chai-enzyme to be compatible with the soon-to-be-released Enzyme 3.0. There were a couple of things being used in chai-enzyme that were "private" from enzyme, but you can use public APIs to achieve the same result. Most everything else should not break any of chai-enzyme's functionality.
The one caveat is that enzyme v3 pulls in the new 1.x version of cheerio, which appears to break a handful of the render tests in this repo. I don't have a ton of context around 1) what changed in cheerio from 0.x => 1.x and 2) how chai and this repo really work, so I was really struggling on getting these tests to pass. I was hoping I could get a bit of guidance here.