Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 16 and enzyme 3 compatibility for jest-enzyme #160

Closed
fernandopasik opened this issue Sep 26, 2017 · 7 comments
Closed

React 16 and enzyme 3 compatibility for jest-enzyme #160

fernandopasik opened this issue Sep 26, 2017 · 7 comments

Comments

@fernandopasik
Copy link
Contributor

fernandopasik commented Sep 26, 2017

Hi!
Enzyme 3 and React 16 are out now, and trying to use them I'm detecting the following error on my test runs with jest:

Cannot find module 'enzyme/build/ShallowTraversal' from 'shallow.js'

I suspect that has something to do with enzyme-to-json being outdated as well, but now v3.0 is out.

@fernandopasik fernandopasik changed the title React 16 and enzyme 3 compatibility React 16 and enzyme 3 compatibility for jest-enzyme Sep 26, 2017
@fernandopasik
Copy link
Contributor Author

After doing an update of enzyme-to-json to v3.0, some tests run now but a lot of them are throwing this error:

Attempted to access ShallowWrapper::nodes, which was previously a private property on
Enzyme ShallowWrapper instances, but is no longer and should not be relied upon.
Consider using the getElements() method instead.

@blainekasten
Copy link
Collaborator

I've been looking at this for the past hour. It's going to take a decent amount of work as many internal things changed.. I should be able to spend a good amount of time tomorrow working on it. So hopefully it'll just take a day or two.

@csvan
Copy link

csvan commented Sep 27, 2017

+1

@blainekasten
Copy link
Collaborator

Cutting a release in 2m.

@blainekasten
Copy link
Collaborator

Try 4.0.0!

@fernandopasik
Copy link
Contributor Author

Thanks for the hard work @blainekasten !! An awesome library you did!!

@blainekasten
Copy link
Collaborator

❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants