[Tests] work around React < 15 mount errors with certain HTML tags

enzymejs · Jan 27, 2019 · 018ff33 · 018ff33
1 parent ef6c8b3
commit 018ff33
Show file tree

Hide file tree

Showing 3 changed files with 31 additions and 7 deletions.
diff --git a/packages/enzyme-test-suite/package.json b/packages/enzyme-test-suite/package.json
@@ -56,4 +56,4 @@
     "eslint-plugin-react": "^7.12.4",
     "react-is": "^16.7.0"
   }
-}
+}
diff --git a/packages/enzyme-test-suite/test/ReactWrapper-spec.jsx b/packages/enzyme-test-suite/test/ReactWrapper-spec.jsx
@@ -1528,6 +1528,28 @@ describeWithDOM('mount', () => {
       });
     });
 
+    // in React 0.13 and 0.14, these HTML tags get moved around by the DOM, and React fails
+    // they're tested in `shallow`, and in React 15+, so we can skip them here.
+    const tagsWithRenderError = new Set([
+      'body',
+      'frame',
+      'frameset',
+      'head',
+      'html',
+      'caption',
+      'td',
+      'th',
+      'tr',
+      'col',
+      'colgroup',
+      'tbody',
+      'thead',
+      'tfoot',
+    ]);
+    function hasRenderError(Tag) {
+      return is('< 15') && tagsWithRenderError.has(Tag);
+    }
+
     describeWithDOM('find DOM elements by constructor', () => {
       const { elements, all } = getData();
 
@@ -1541,11 +1563,12 @@ describeWithDOM('mount', () => {
           }
         }
 
-        it(`${Tag}: finds by constructor “${name}”`, () => {
+        itIf(!hasRenderError(Tag), `${Tag}: found with \`${name}\``, () => {
           const wrapper = mount(<Foo />);
 
-          expect(wrapper.childAt(0).type()).to.equal(Tag);
-          expect(wrapper.childAt(0).is(Tag)).to.equal(true);
+          const rendered = wrapper.childAt(0);
+          expect(rendered.type()).to.equal(Tag);
+          expect(rendered.is(Tag)).to.equal(true);
           expect(wrapper.find(Tag)).to.have.lengthOf(1);
         });
       });

diff --git a/packages/enzyme-test-suite/test/ShallowWrapper-spec.jsx b/packages/enzyme-test-suite/test/ShallowWrapper-spec.jsx
@@ -1539,11 +1539,12 @@ describe('shallow', () => {
           }
         }
 
-        it(`${Tag}: finds by constructor “${name}”`, () => {
+        it(`${Tag}: found with \`${name}\``, () => {
           const wrapper = shallow(<Foo />);
 
-          expect(wrapper.type()).to.equal(Tag);
-          expect(wrapper.is(Tag)).to.equal(true);
+          const rendered = wrapper;
+          expect(rendered.type()).to.equal(Tag);
+          expect(rendered.is(Tag)).to.equal(true);
           expect(wrapper.filter(Tag)).to.have.lengthOf(1);
         });
       });