[Tests] fail early if describeIf/itIf receives a non-boolean

enzymejs · Jul 27, 2018 · 30b7970 · 30b7970
1 parent d602a22
commit 30b7970
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 2 deletions.
diff --git a/packages/enzyme-test-suite/test/ReactWrapper-spec.jsx b/packages/enzyme-test-suite/test/ReactWrapper-spec.jsx
@@ -4235,7 +4235,7 @@ describeWithDOM('mount', () => {
       });
     });
 
-  describeIf(ITERATOR_SYMBOL, '@@iterator', () => {
+  describeIf(!!ITERATOR_SYMBOL, '@@iterator', () => {
     it('should be iterable', () => {
       class Foo extends React.Component {
         render() {

diff --git a/packages/enzyme-test-suite/test/ShallowWrapper-spec.jsx b/packages/enzyme-test-suite/test/ShallowWrapper-spec.jsx
@@ -5173,7 +5173,7 @@ describe('shallow', () => {
     });
   });
 
-  describeIf(ITERATOR_SYMBOL, '@@iterator', () => {
+  describeIf(!!ITERATOR_SYMBOL, '@@iterator', () => {
     it('should be iterable', () => {
       class Foo extends React.Component {
         render() {

diff --git a/packages/enzyme-test-suite/test/_helpers/index.jsx b/packages/enzyme-test-suite/test/_helpers/index.jsx
@@ -7,6 +7,10 @@ import React from 'react';
  * determines whether or not the test will be run
  */
 export function describeIf(test, a, b) {
+  if (typeof test !== 'boolean') {
+    throw new TypeError(`a boolean is required, you passed a ${typeof test}`);
+  }
+
   if (test) {
     describe(a, b);
   } else {
@@ -19,6 +23,10 @@ export function describeIf(test, a, b) {
  * determines whether or not the test will be run
  */
 export function itIf(test, a, b) {
+  if (typeof test !== 'boolean') {
+    throw new TypeError(`a boolean is required, you passed a ${typeof test}`);
+  }
+
   if (test) {
     it(a, b);
   } else {