[enzyme-shallow-equal] v1.0.0

 - [enzyme-adapter-react-16, enzyme] use `enzyme-shallow-equal`

packages/enzyme-adapter-react-16/package.json

@@ -36,6 +36,7 @@
   "license": "MIT",
   "dependencies": {
     "enzyme-adapter-utils": "^1.12.0",
+    "enzyme-shallow-equal": "^1.0.0",
     "has": "^1.0.3",
     "object.assign": "^4.1.0",
     "object.values": "^1.1.0",

packages/enzyme-adapter-react-16/src/ReactSixteenAdapter.js

@@ -36,7 +36,8 @@ import {
   Suspense,
 } from 'react-is';
 import { EnzymeAdapter } from 'enzyme';
-import { typeOfNode, shallowEqual } from 'enzyme/build/Utils';
+import { typeOfNode } from 'enzyme/build/Utils';
+import shallowEqual from 'enzyme-shallow-equal';
 import {
   displayNameOfNode,
   elementToTree as utilElementToTree,

packages/enzyme-shallow-equal/.babelrc

@@ -0,0 +1,7 @@
+{
+  "presets": ["airbnb"],
+  "plugins": [
+    ["transform-replace-object-assign", { "moduleSpecifier": "object.assign" }],
+  ],
+  sourceMaps: "both",
+}

packages/enzyme-shallow-equal/.eslintignore

@@ -0,0 +1 @@
+../../.eslintignore

packages/enzyme-shallow-equal/.eslintrc

@@ -0,0 +1,4 @@
+{
+  "root": true,
+  "extends": "airbnb-base"
+}

packages/enzyme-shallow-equal/.npmignore

@@ -0,0 +1 @@
+../../.npmignore

packages/enzyme-shallow-equal/.npmrc

@@ -0,0 +1 @@
+../../.npmrc

packages/enzyme-shallow-equal/README.md

@@ -0,0 +1,5 @@
+# enzyme-shallow-equal
+
+This is the implementation of shallowEqual that enzyme uses.
+
+It's adapted from https://github.com/facebook/react/blob/144328fe81719e916b946e22660479e31561bb0b/packages/shared/shallowEqual.js#L36-L68

packages/enzyme-shallow-equal/package.json

@@ -0,0 +1,53 @@
+{
+  "name": "enzyme-shallow-equal",
+  "version": "1.0.0",
+  "description": "Adaptation of react-addons-shallow-compare, for independent usage",
+  "homepage": "http://airbnb.io/enzyme/",
+  "main": "build",
+  "scripts": {
+    "clean": "rimraf build",
+    "lint": "eslint --ext js,jsx .",
+    "pretest": "npm run lint",
+    "prebuild": "npm run clean",
+    "build": "babel --source-maps=both src --out-dir build",
+    "watch": "npm run build -- -w",
+    "prepublish": "npm run build && safe-publish-latest && (not-in-publish || cp ../../LICENSE.md ./)"
+  },
+  "repository": {
+    "type": "git",
+    "url": "https://github.com/airbnb/enzyme.git",
+    "directory": "packages/enzyme-shallow-equal"
+  },
+  "keywords": [
+    "javascript",
+    "shallow rendering",
+    "shallowRender",
+    "test",
+    "reactjs",
+    "react",
+    "flux",
+    "testing",
+    "test utils",
+    "assertion helpers",
+    "tdd",
+    "mocha"
+  ],
+  "author": "Jordan Harband <ljharb@gmail.com>",
+  "license": "MIT",
+  "dependencies": {
+    "has": "^1.0.3",
+    "object-is": "^1.0.1"
+  },
+  "peerDependencies": {},
+  "devDependencies": {
+    "babel-cli": "^6.26.0",
+    "babel-plugin-transform-replace-object-assign": "^1.0.0",
+    "babel-preset-airbnb": "^2.6.0",
+    "eslint": "^5.16.0",
+    "eslint-config-airbnb-base": "^13.1.0",
+    "eslint-plugin-import": "^2.17.3",
+    "in-publish": "^2.0.0",
+    "rimraf": "^2.6.3",
+    "safe-publish-latest": "^1.1.2"
+  }
+}

packages/enzyme-shallow-equal/src/index.js

@@ -0,0 +1,32 @@
+import is from 'object-is';
+import has from 'has';
+
+// adapted from https://github.com/facebook/react/blob/144328fe81719e916b946e22660479e31561bb0b/packages/shared/shallowEqual.js#L36-L68
+export default function shallowEqual(objA, objB) {
+  if (is(objA, objB)) {
+    return true;
+  }
+
+  if (!objA || !objB || typeof objA !== 'object' || typeof objB !== 'object') {
+    return false;
+  }
+
+  const keysA = Object.keys(objA);
+  const keysB = Object.keys(objB);
+
+  if (keysA.length !== keysB.length) {
+    return false;
+  }
+
+  keysA.sort();
+  keysB.sort();
+
+  // Test for A's keys different from B.
+  for (let i = 0; i < keysA.length; i += 1) {
+    if (!has(objB, keysA[i]) || !is(objA[keysA[i]], objB[keysA[i]])) {
+      return false;
+    }
+  }
+
+  return true;
+}

packages/enzyme-test-suite/package.json

@@ -35,6 +35,7 @@
     "enzyme": "^3.9.0",
     "enzyme-adapter-react-helper": "^1.3.3",
     "enzyme-adapter-utils": "^1.10.1",
+    "enzyme-shallow-equal": "^1.0.0",
     "html-element-map": "^1.0.1",
     "jsdom": "^6.5.1",
     "lodash.isequal": "^4.5.0",

packages/enzyme-test-suite/test/enzyme-shallow-equal-spec.js

@@ -0,0 +1,49 @@
+import shallowEqual from 'enzyme-shallow-equal';
+
+import { expect } from 'chai';
+
+describe('shallowEqual', () => {
+  it('returns true for things that are SameValue', () => {
+    [{}, [], NaN, 42, 'foo', '', 0, Infinity, () => {}, /a/g, true, false, null, undefined].forEach((x) => {
+      expect(shallowEqual(x, x)).to.equal(true);
+    });
+  });
+
+  it('returns false if one is falsy and one is truthy', () => {
+    [null, undefined, false, 0, NaN].forEach((x) => {
+      expect(shallowEqual(true, x)).to.equal(false);
+    });
+  });
+
+  it('returns true if both have zero keys', () => {
+    expect(shallowEqual({}, {})).to.equal(true);
+  });
+
+  it('returns false if they have different numbers of keys', () => {
+    expect(shallowEqual({ a: 1 }, {})).to.equal(false);
+    expect(shallowEqual({}, { a: 1 })).to.equal(false);
+  });
+
+  it('returns false if they have the same number, but differently named, keys', () => {
+    expect(shallowEqual({ a: 1 }, { b: 1 })).to.equal(false);
+  });
+
+  it('returns false if they have the same keys, with different values', () => {
+    [{}, [], NaN, 42, 'foo', '', 0, Infinity, () => {}, /a/g, true, false, null, undefined].forEach((x) => {
+      expect(shallowEqual({ a: x }, { a: {} })).to.equal(false);
+      expect(shallowEqual({ a: {} }, { a: x })).to.equal(false);
+    });
+  });
+
+  it('returns false if an undefined key in one is absent in the other', () => {
+    expect(shallowEqual({ a: undefined, b: true }, { b: true, c: undefined })).to.equal(false);
+    expect(shallowEqual({ c: undefined, b: true }, { b: true, a: undefined })).to.equal(false);
+  });
+
+  it('returns true if they have the same keys, with the same values', () => {
+    [{}, [], NaN, 42, 'foo', '', 0, Infinity, () => {}, /a/g, true, false, null, undefined].forEach((x) => {
+      expect(shallowEqual({ a: x }, { a: x })).to.equal(true);
+      expect(shallowEqual({ a: x }, { a: x })).to.equal(true);
+    });
+  });
+});

packages/enzyme/package.json

@@ -37,6 +37,7 @@
   "dependencies": {
     "array.prototype.flat": "^1.2.1",
     "cheerio": "^1.0.0-rc.2",
+    "enzyme-shallow-equal": "^1.0.0",
     "function.prototype.name": "^1.1.0",
     "has": "^1.0.3",
     "html-element-map": "^1.0.0",

packages/enzyme/src/ShallowWrapper.js

@@ -1,6 +1,7 @@
 import flat from 'array.prototype.flat';
 import cheerio from 'cheerio';
 import has from 'has';
+import shallowEqual from 'enzyme-shallow-equal';
 
 import {
   nodeEqual,
@@ -18,7 +19,6 @@ import {
   privateSet,
   cloneElement,
   spyMethod,
-  shallowEqual,
   isEmptyValue,
 } from './Utils';
 import getAdapter from './getAdapter';

packages/enzyme/src/Utils.js

@@ -330,36 +330,7 @@ export function spyMethod(instance, methodName, getStub = () => {}) {
   };
 }
 
-// adapted from https://github.com/facebook/react/blob/144328fe81719e916b946e22660479e31561bb0b/packages/shared/shallowEqual.js#L36-L68
-export function shallowEqual(objA, objB) {
-  if (is(objA, objB)) {
-    return true;
-  }
-
-
-  if (!objA || !objB || typeof objA !== 'object' || typeof objB !== 'object') {
-    return false;
-  }
-
-  const keysA = Object.keys(objA);
-  const keysB = Object.keys(objB);
-
-  if (keysA.length !== keysB.length) {
-    return false;
-  }
-
-  keysA.sort();
-  keysB.sort();
-
-  // Test for A's keys different from B.
-  for (let i = 0; i < keysA.length; i += 1) {
-    if (!has(objB, keysA[i]) || !is(objA[keysA[i]], objB[keysA[i]])) {
-      return false;
-    }
-  }
-
-  return true;
-}
+export { default as shallowEqual } from 'enzyme-shallow-equal';
 
 export function isEmptyValue(renderedValue) {
   return renderedValue === null || renderedValue === false;