[Tests] add tests for UNSAFE_componentWillReceiveProps

Closes #1690.
enzymejs · Jul 9, 2018 · c40c0fd · c40c0fd
1 parent cfc5a3e
commit c40c0fd
Show file tree

Hide file tree

Showing 2 changed files with 62 additions and 16 deletions.
diff --git a/packages/enzyme-test-suite/test/ReactWrapper-spec.jsx b/packages/enzyme-test-suite/test/ReactWrapper-spec.jsx
@@ -1198,28 +1198,51 @@ describeWithDOM('mount', () => {
     });
 
     it('should call componentWillReceiveProps for new renders', () => {
-      const spy = sinon.spy();
+      const stateValue = {};
 
       class Foo extends React.Component {
         constructor(props) {
           super(props);
-          this.componentWillReceiveProps = spy;
+          this.state = { stateValue };
         }
 
+        componentWillReceiveProps() {}
+
+        UNSAFE_componentWillReceiveProps() {} // eslint-disable-line camelcase
+
         render() {
+          const { id } = this.props;
+          const { stateValue: val } = this.state;
           return (
-            <div className={this.props.id}>
-              {this.props.id}
+            <div className={id}>
+              {val}
             </div>
           );
         }
       }
+      Foo.contextTypes = {
+        foo() { return null; },
+      };
+      const cWRP = sinon.stub(Foo.prototype, 'componentWillReceiveProps');
+      // eslint-disable-next-line camelcase
+      const U_cWRP = sinon.stub(Foo.prototype, 'UNSAFE_componentWillReceiveProps');
+
       const nextProps = { id: 'bar', foo: 'bla' };
-      const wrapper = mount(<Foo id="foo" />);
-      expect(spy.calledOnce).to.equal(false);
+      const context = { foo: 'bar' };
+      const wrapper = mount(<Foo id="foo" />, { context });
+
+      expect(cWRP).to.have.property('callCount', 0);
+      expect(U_cWRP).to.have.property('callCount', 0);
+
       wrapper.setProps(nextProps);
-      expect(spy.calledOnce).to.equal(true);
-      expect(spy.calledWith(nextProps)).to.equal(true);
+
+      expect(cWRP).to.have.property('callCount', 1);
+      expect(cWRP.calledWith(nextProps, context)).to.equal(true);
+
+      if (REACT163) {
+        expect(U_cWRP).to.have.property('callCount', 1);
+        expect(U_cWRP.calledWith(nextProps, context)).to.equal(true);
+      }
     });
 
     it('should merge newProps with oldProps', () => {

diff --git a/packages/enzyme-test-suite/test/ShallowWrapper-spec.jsx b/packages/enzyme-test-suite/test/ShallowWrapper-spec.jsx
@@ -1065,28 +1065,51 @@ describe('shallow', () => {
     });
 
     it('should call componentWillReceiveProps for new renders', () => {
-      const spy = sinon.spy();
+      const stateValue = {};
 
       class Foo extends React.Component {
         constructor(props) {
           super(props);
-          this.componentWillReceiveProps = spy;
+          this.state = { stateValue };
         }
 
+        componentWillReceiveProps() {}
+
+        UNSAFE_componentWillReceiveProps() {} // eslint-disable-line camelcase
+
         render() {
+          const { id } = this.props;
+          const { stateValue: val } = this.state;
           return (
-            <div className={this.props.id}>
-              {this.props.id}
+            <div className={id}>
+              {val}
             </div>
           );
         }
       }
+      Foo.contextTypes = {
+        foo() { return null; },
+      };
+      const cWRP = sinon.stub(Foo.prototype, 'componentWillReceiveProps');
+      // eslint-disable-next-line camelcase
+      const U_cWRP = sinon.stub(Foo.prototype, 'UNSAFE_componentWillReceiveProps');
+
       const nextProps = { id: 'bar', foo: 'bla' };
-      const wrapper = shallow(<Foo id="foo" />);
-      expect(spy.calledOnce).to.equal(false);
+      const context = { foo: 'bar' };
+      const wrapper = shallow(<Foo id="foo" />, { context });
+
+      expect(cWRP).to.have.property('callCount', 0);
+      expect(U_cWRP).to.have.property('callCount', 0);
+
       wrapper.setProps(nextProps);
-      expect(spy.calledOnce).to.equal(true);
-      expect(spy.calledWith(nextProps)).to.equal(true);
+
+      expect(cWRP).to.have.property('callCount', 1);
+      expect(cWRP.calledWith(nextProps, context)).to.equal(true);
+
+      if (REACT163) {
+        expect(U_cWRP).to.have.property('callCount', 1);
+        expect(U_cWRP.calledWith(nextProps, context)).to.equal(true);
+      }
     });
 
     it('should merge newProps with oldProps', () => {