Skip to content

Commit

Permalink
Replace to.be.true assertion with to.equal(true) per style guide
Browse files Browse the repository at this point in the history
  • Loading branch information
@erikthedeveloper
erikthedeveloper committed Dec 29, 2015
1 parent 465bca0 commit d00c142
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion docs/api/ShallowWrapper/forEach.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ const wrapper = shallow(
);

wrapper.find('.foo').forEach(function (node) {
expect(node.hasClass('foo')).to.be.true;
expect(node.hasClass('foo')).to.equal(true);
});
```

Expand Down

2 comments on commit d00c142

@erikthedeveloper
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ljharb I fixed only this instance based on your comment

Our styleguide prohibits noop expressions which includes .to.be.true

I see that there are a number of existing violations throughout the docs. I'm sure this could make a good Your First PR for someone if posted as an issue.

image

@ljharb
Copy link
Member

@ljharb ljharb commented on d00c142 Dec 29, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely, I didn't intend to increase the scope of your PR :-) thanks!

Please sign in to comment.