Added render and html methods for ShallowWrapper #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lelandrichardson
force-pushed
the
lmr/render-and-html-methods-for-shallow
branch
from
96e216f
to
21a28da
Compare
| @@ -0,0 +1,40 @@ | |||
| # `.render() => CheerioWrapper` | |||
|
|
|||
| Returns a CheerioWrapper around the rendered HTML of the current node's subtree. | |||
There was a problem hiding this comment.
Since I can do import { render } from 'reagent', I'd expect foo.render() to be a convenience method for render(foo.get(0)). Is this what it's doing? (the full render docs don't exist yet)
There was a problem hiding this comment.
Yes, this is effectively what it's doing.
|
LGTM |
lelandrichardson
force-pushed
the
lmr/render-and-html-methods-for-shallow
branch
from
21a28da
to
18196e1
Compare
lelandrichardson
added a commit
that referenced
this pull request
Nov 16, 2015
…allow Added render and html methods for ShallowWrapper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
.render()and a.html()method to the ShallowWrapper prototype. These are mainly convenience methods and allow the user to fluidly switch between shallow rendering and static rendering for pieces of the tree, which can actually be quite useful if you want to assert something HTML related, but you also want to use the shallow API to set state and simulate events and other things that the static renderer cannot do.Related Issues: #11 and #2