Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
  • Loading branch information
h1alexbel committed Jul 10, 2023
1 parent 316774a commit c8f5128
Show file tree
Hide file tree
Showing 5 changed files with 75 additions and 15 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ Since version `0.5.6` you can create Producer with YAML file:
```java
final Producer<String, String> producer = new KfProducer<>(
new KfYamlProducerSettings<>(
new YamlMapParams<String, String>("producer.yaml")
"producer.yaml"
)
);
```
Expand Down Expand Up @@ -270,7 +270,7 @@ Since version `0.5.6` you can create Consumer with YAML file:
```java
final Consumer<String, String> consumer = new KfConsumer<>(
new KfYamlConsumerSettings<>(
new YamlMapParams<String, String>("consumer.yaml")
"consumer.yaml"
)
);
```
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
package io.github.eocqrs.kafka.yaml;

import io.github.eocqrs.kafka.ConsumerSettings;
import lombok.RequiredArgsConstructor;
import org.apache.kafka.clients.consumer.KafkaConsumer;

/**
Expand All @@ -32,14 +31,32 @@
* @param <K> The key type.
* @param <X> The value type.
*/
@RequiredArgsConstructor
public final class KfYamlConsumerSettings<K, X>
implements ConsumerSettings<K, X> {

/**
* YAML params.
*/
private final YamlMapParams<K, X> params;
private final YamlMapParams params;

/**
* Ctor.
*
* @param prms YAML Params
*/
public KfYamlConsumerSettings(final YamlMapParams prms) {
this.params = prms;
}

/**
* Ctor.
*
* @param nm YAML file name
* @throws Exception when something went wrong
*/
public KfYamlConsumerSettings(final String nm) throws Exception {
this(new YamlMapParams(nm));
}

@Override
public KafkaConsumer<K, X> consumer() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@
package io.github.eocqrs.kafka.yaml;

import io.github.eocqrs.kafka.ProducerSettings;
import lombok.RequiredArgsConstructor;
import org.apache.kafka.clients.producer.KafkaProducer;

/**
Expand All @@ -32,14 +31,32 @@
* @param <K> The key type.
* @param <X> The value type.
*/
@RequiredArgsConstructor
public final class KfYamlProducerSettings<K, X>
implements ProducerSettings<K, X> {

/**
* YAML params.
*/
private final YamlMapParams<K, X> params;
private final YamlMapParams params;

/**
* Ctor.
*
* @param prms YAML Params
*/
public KfYamlProducerSettings(final YamlMapParams prms) {
this.params = prms;
}

/**
* Ctor.
*
* @param nm YAML file name
* @throws Exception when something went wrong
*/
public KfYamlProducerSettings(final String nm) throws Exception {
this(new YamlMapParams(nm));
}

@Override
public KafkaProducer<K, X> producer() {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,29 @@
/**
* Test case for {@link KfYamlProducerSettings}.
*/
class KfYamlConsumerSettingsTest {
final class KfYamlConsumerSettingsTest {

@Test
void createsConsumerFromYamlConfiguration() {
assertDoesNotThrow(
() ->
new KfConsumer<>(
new KfConsumer<String, String>(
new KfYamlConsumerSettings<>(
new YamlMapParams<String, String>("consumer.yaml")
new YamlMapParams(
"consumer.yaml"
)
)
)
);
}

@Test
void createsConsumerFromYamlFileName() {
assertDoesNotThrow(
() ->
new KfConsumer<String, String>(
new KfYamlConsumerSettings<>(
"consumer.yaml"
)
)
);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,18 +30,30 @@
/**
* Test case for {@link KfYamlConsumerSettings}.
*/
class KfYamlProducerSettingsTest {
final class KfYamlProducerSettingsTest {

@Test
void createsProducerFromYaml() {
void createsProducerFromYamlConfiguration() {
assertDoesNotThrow(
() -> new KfProducer<>(
() -> new KfProducer<String, String>(
new KfYamlProducerSettings<>(
new YamlMapParams<String, String>(
new YamlMapParams(
"producer.yaml"
)
)
)
);
}

@Test
void createsProducerFromYamlFileName() {
assertDoesNotThrow(
() ->
new KfProducer<String, String>(
new KfYamlProducerSettings<>(
"producer.yaml"
)
)
);
}
}

0 comments on commit c8f5128

Please sign in to comment.