Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka Shutdown Hook #356

Closed
h1alexbel opened this issue Jun 7, 2023 · 5 comments · Fixed by #352
Closed

Kafka Shutdown Hook #356

h1alexbel opened this issue Jun 7, 2023 · 5 comments · Fixed by #352
Assignees

Comments

@h1alexbel
Copy link
Member

implement abstraction over Shutdown Hook for safe Consumer shutdown management

@zoeself
Copy link
Collaborator

zoeself commented Jun 7, 2023

@h1alexbel thank you for reporting this. I'll assign someone to take care of it soon.

@zoeself
Copy link
Collaborator

zoeself commented Jun 7, 2023

@l3r8yJ this is your task now, please go ahead. Deadline (when this ticket should be closed) is 2023-06-17T09:29:06.873605.

Estimation here is 60 minutes, that's how much you will be paid.

Remember, you don't have to solve everything in this ticket - you can solve it partially and leave todo markers in the code, which will become future tasks.

If you have any questions don't ask me, I'm not a technical person. Open new tickets instead.

If you don't have time or simply don't want to work on this, you can always resign.

@h1alexbel
Copy link
Member Author

@zoeself deregister

@zoeself zoeself removed the @l3r8yJ label Jun 7, 2023
@zoeself
Copy link
Collaborator

zoeself commented Jun 7, 2023

@zoeself deregister

@h1alexbel ok, I've removed this task from scope. I'm not managing it anymore.

@h1alexbel h1alexbel linked a pull request Jun 7, 2023 that will close this issue
@h1alexbel h1alexbel self-assigned this Jun 7, 2023
h1alexbel added a commit that referenced this issue Jun 12, 2023
@h1alexbel
Copy link
Member Author

h1alexbel commented Jun 12, 2023

due to the untestability of this logic, for now, we skip the implementation of the shutdown hook

@h1alexbel h1alexbel closed this as not planned Won't fix, can't repro, duplicate, stale Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants