-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fake consumer records #392
Conversation
@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon. If this PR solves a |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #392 +/- ##
============================================
+ Coverage 97.86% 98.23% +0.37%
- Complexity 157 164 +7
============================================
Files 73 75 +2
Lines 421 453 +32
Branches 1 1
============================================
+ Hits 412 445 +33
+ Misses 9 8 -1
☔ View full report in Codecov by Sentry. |
@l3r8yJ please review this Pull Request. Deadline (when it should be merged or closed) is You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough. Estimation here is |
@l3r8yJ unfortunately FkConsumer#125-126 cannot be covered |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@h1alexbel looks cool, just 1 small fix
Co-authored-by: Ivan Ivanchuk <clicker.heroes.acg@gmail.com>
@h1alexbel I also suggest to set this flag to eo-kafka/.github/workflows/codecov.yml Line 28 in ef899c7
|
@l3r8yJ thank you for resolving this ticket. I've just added it to your active invoice. You can always check all your invoices and more on the Contributor Dashboard. |
@l3r8yJ take a look, please
closes #303
PR-Codex overview
This PR adds functionality to the Kafka fake consumer, including support for various data types and a timeout for reading records. It also includes some minor changes and bug fixes.
Detailed summary