Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flexible message producing #401

Merged
merged 4 commits into from
Jun 29, 2023
Merged

flexible message producing #401

merged 4 commits into from
Jun 29, 2023

Conversation

h1alexbel
Copy link
Member

@h1alexbel h1alexbel commented Jun 29, 2023

closes #304


PR-Codex overview

This PR focuses on deprecating and replacing certain classes and interfaces in the codebase.

Detailed summary

  • KfData class is deprecated and replaced with Message class.
  • DatasetDirs class is marked as deprecated.
  • Data interface is deprecated and replaced with Message interface.
  • Added a new dependency eo-kafka in the pom.xml file.
  • Updated test cases to reflect the changes in the codebase.

The following files were skipped due to too many changes: src/main/java/io/github/eocqrs/kafka/Message.java, src/main/java/io/github/eocqrs/kafka/fake/FkProducer.java, src/it/producer-consumer-api/src/test/java/ProducerTest.java, src/test/java/io/github/eocqrs/kafka/data/TkvTest.java, src/main/java/io/github/eocqrs/kafka/data/Tkv.java, src/test/java/io/github/eocqrs/kafka/data/TimestampedTest.java, src/test/java/io/github/eocqrs/kafka/data/WithPartitionTest.java, src/main/java/io/github/eocqrs/kafka/data/WithPartition.java, src/main/java/io/github/eocqrs/kafka/data/Timestamped.java, README.md

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@zoeself
Copy link
Collaborator

zoeself commented Jun 29, 2023

@h1alexbel thank you for your Pull Request. I'll assign someone to review it soon.

If this PR solves a todo from the code, please don't forget to remove it.

@zoeself
Copy link
Collaborator

zoeself commented Jun 29, 2023

@l3r8yJ please review this Pull Request. Deadline (when it should be merged or closed) is 2023-07-02T13:29:07.907202.

You should check if the requirements have been implemented (partially or in full), if there are unit tests covering the changes and if the CI build passes. Feel free to reject the PR or ask for changes if it's too big or not clear enough.

Estimation here is 30 minutes, that's how much you will be paid. You will be paid even if this PR gets rejected.

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Patch coverage: 97.50% and project coverage change: +0.71 🎉

Comparison is base (3480a0a) 98.23% compared to head (a964e93) 98.94%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #401      +/-   ##
============================================
+ Coverage     98.23%   98.94%   +0.71%     
- Complexity      164      170       +6     
============================================
  Files            75       78       +3     
  Lines           453      476      +23     
  Branches          1        1              
============================================
+ Hits            445      471      +26     
+ Misses            8        5       -3     
Impacted Files Coverage Δ
.../main/java/io/github/eocqrs/kafka/data/KfData.java 100.00% <ø> (ø)
.../java/io/github/eocqrs/kafka/fake/DatasetDirs.java 100.00% <ø> (ø)
...va/io/github/eocqrs/kafka/producer/KfProducer.java 87.50% <0.00%> (+23.86%) ⬆️
.../java/io/github/eocqrs/kafka/data/Timestamped.java 100.00% <100.00%> (ø)
src/main/java/io/github/eocqrs/kafka/data/Tkv.java 100.00% <100.00%> (ø)
...ava/io/github/eocqrs/kafka/data/WithPartition.java 100.00% <100.00%> (ø)
...n/java/io/github/eocqrs/kafka/fake/FkProducer.java 100.00% <100.00%> (ø)
...va/io/github/eocqrs/kafka/producer/KfCallback.java 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@h1alexbel
Copy link
Member Author

@zoeself deregister

@zoeself
Copy link
Collaborator

zoeself commented Jun 29, 2023

@zoeself deregister

@h1alexbel ok, I've removed this task from scope. I'm not managing it anymore.

@h1alexbel h1alexbel merged commit 42859f7 into master Jun 29, 2023
7 of 8 checks passed
@h1alexbel h1alexbel deleted the 331 branch June 29, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Producer.java:29: Producer send is not flexible enough
3 participants