relax throws clause in overridden methods that do not throw (eclipse-…

…platform#1467) * relax throws clause in overridden methods that do not throw
eobrienPilz · Jan 9, 2024 · 5d26487 · 5d26487
1 parent b53ea1d
commit 5d26487
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 8 deletions.
diff --git a/...es/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ActivateEditorHandler.java b/...es/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/ActivateEditorHandler.java
@@ -20,7 +20,6 @@
 import org.eclipse.core.expressions.Expression;
 import org.eclipse.core.expressions.ExpressionInfo;
 import org.eclipse.core.expressions.IEvaluationContext;
-import org.eclipse.core.runtime.CoreException;
 import org.eclipse.ui.IEditorPart;
 import org.eclipse.ui.ISources;
 import org.eclipse.ui.IViewReference;
@@ -72,7 +71,7 @@ protected Expression getEnabledWhenExpression() {
 		if (enabledWhen == null) {
 			enabledWhen = new Expression() {
 				@Override
-				public EvaluationResult evaluate(IEvaluationContext context) throws CoreException {
+				public EvaluationResult evaluate(IEvaluationContext context) {
 					IWorkbenchWindow window = InternalHandlerUtil.getActiveWorkbenchWindow(context);
 					if (window != null) {
 						if (window.getActivePage() != null) {

diff --git a/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchConfigurer.java b/bundles/org.eclipse.ui.workbench/Eclipse UI/org/eclipse/ui/internal/WorkbenchConfigurer.java
@@ -23,7 +23,6 @@
 import org.eclipse.ui.IWorkbench;
 import org.eclipse.ui.IWorkbenchWindow;
 import org.eclipse.ui.PlatformUI;
-import org.eclipse.ui.WorkbenchException;
 import org.eclipse.ui.application.IWorkbenchConfigurer;
 import org.eclipse.ui.application.IWorkbenchWindowConfigurer;
 import org.eclipse.ui.application.WorkbenchAdvisor;
@@ -167,7 +166,7 @@ public void openFirstTimeWindow() {
 	}
 
 	@Override
-	public IWorkbenchWindowConfigurer restoreWorkbenchWindow(IMemento memento) throws WorkbenchException {
+	public IWorkbenchWindowConfigurer restoreWorkbenchWindow(IMemento memento) {
 		return getWindowConfigurer(null);
 	}
 

diff --git a/....workbench/Eclipse UI/org/eclipse/ui/internal/browser/DefaultWorkbenchBrowserSupport.java b/....workbench/Eclipse UI/org/eclipse/ui/internal/browser/DefaultWorkbenchBrowserSupport.java
@@ -15,7 +15,6 @@
 
 import java.util.HashMap;
 import java.util.Map;
-import org.eclipse.ui.PartInitException;
 import org.eclipse.ui.browser.AbstractWorkbenchBrowserSupport;
 import org.eclipse.ui.browser.IWebBrowser;
 
@@ -53,13 +52,13 @@ IWebBrowser findBrowser(String id) {
 	}
 
 	protected IWebBrowser doCreateBrowser(int style, String browserId, String name, String tooltip)
-			throws PartInitException {
+	{
 		return new DefaultWebBrowser(this, browserId);
 	}
 
 	@Override
 	public IWebBrowser createBrowser(int style, String browserId, String name, String tooltip)
-			throws PartInitException {
+	{
 		IWebBrowser browser = findBrowser(browserId == null ? getDefaultId() : browserId);
 		if (browser != null) {
 			return browser;
@@ -70,7 +69,7 @@ public IWebBrowser createBrowser(int style, String browserId, String name, Strin
 	}
 
 	@Override
-	public IWebBrowser createBrowser(String browserId) throws PartInitException {
+	public IWebBrowser createBrowser(String browserId) {
 		return createBrowser(AS_EXTERNAL, browserId, null, null);
 	}