Close resource actions should use the property tooltip property (ecli…

…pse-platform#498) Where IDEWorkbenchMessages.CloseResourceAction_text is used to create an action, IDEWorkbenchMessages.CloseResourceAction_toolTip should be used for the tooltip of that action. Fixes eclipse-platform/eclipse.platform#304
eobrienPilz · Dec 21, 2022 · 986db40 · 986db40
1 parent a537256
commit 986db40
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/ide/IDEActionFactory.java b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/ide/IDEActionFactory.java
@@ -206,7 +206,7 @@ public IWorkbenchAction create(IWorkbenchWindow window) {
 				throw new IllegalArgumentException();
 			}
 			RetargetAction action = new RetargetAction(getId(), IDEWorkbenchMessages.CloseResourceAction_text);
-			action.setToolTipText(IDEWorkbenchMessages.CloseResourceAction_text);
+			action.setToolTipText(IDEWorkbenchMessages.CloseResourceAction_toolTip);
 			window.getPartService().addPartListener(action);
 			action.setActionDefinitionId(getCommandId());
 			return action;

diff --git a/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/WorkbenchActionBuilder.java b/bundles/org.eclipse.ui.ide/src/org/eclipse/ui/internal/ide/WorkbenchActionBuilder.java
@@ -1525,7 +1525,7 @@ private IContributionItem getOpenProjectItem() {
 
 	private IContributionItem getCloseProjectItem() {
 		return getItem(IDEActionFactory.CLOSE_PROJECT.getId(), IDEActionFactory.CLOSE_PROJECT.getCommandId(), null,
-				null, IDEWorkbenchMessages.CloseResourceAction_text, IDEWorkbenchMessages.CloseResourceAction_text);
+				null, IDEWorkbenchMessages.CloseResourceAction_text, IDEWorkbenchMessages.CloseResourceAction_toolTip);
 	}
 
 	private IContributionItem getItem(String actionId, String commandId,