Manage git remote for device groups

[nhemingway]

Closes #27

[ghoneycutt]

also should test the two file resources added

[nhemingway]

The existing test asserts that we do in fact behave correctly if asked to manage remote urls (though I should probably add a negative test).

That being the case, whilst I'm happy to add the tests you request, what benefit would they add over the existing test?

[ghoneycutt]

Besides the exec, which you test for, you also added two file resources "post-commit hook for ${name}" and "rancid default git remote ${name}" which should be tested in that same block and are not being tested elsewhere.

[nhemingway]

Given that all three resource are enclosed in the same conditional block, there is no way that any of the three can be included in the catalogue without all of them being included. Therefore, there is no benefit including tests for all three, because they will either pass or fail together. I included a test for the exec purely to test that the condition is working correctly. If we add tests for the other two resources, then surely we're simply repeating the manifest, but not really adding any value?

[ghoneycutt]

You do not need to include all of the attributes though there should be basic, this resource should exist. If the coverage bits were enabled you would get a report at the end showing untested resources. While this might seem like extra work now, as the code changes over time, this ensures proper testing.

 it { should contain_file('asdf') }

[ghoneycutt]

@nhemingway I see you are giving this module some needed attention :) You might look to update the metadata.json to support newer puppet versions and the .travis.yml to test them. Ideally this would support Puppet 6 and 7.

[nhemingway]

@nhemingway I see you are giving this module some needed attention :) You might look to update the metadata.json to support newer puppet versions and the .travis.yml to test them. Ideally this would support Puppet 6 and 7.

I've spawned that work out to #31 as I think it's more involved than just updating a couple of config files. (Not that I know how to update them having never worked with travis before)