Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch:lib] Fix Arx.search query object yielding #20

Merged
merged 1 commit into from
Mar 27, 2019
Merged

[patch:lib] Fix Arx.search query object yielding #20

merged 1 commit into from
Mar 27, 2019

Conversation

eonu
Copy link
Owner

@eonu eonu commented Mar 27, 2019

The following line leads to issues when Arx.search is called with no pre-constructed query, and without a block, since the query variable will not be redefined in this case.

yield query = Query.new(*ids, sort_by: sort_by, sort_order: sort_order) if block_given?

@eonu eonu merged commit 2e05d65 into master Mar 27, 2019
@eonu eonu mentioned this pull request Mar 27, 2019
Merged
@eonu eonu deleted the patch/search branch March 29, 2019 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@eonu