New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[patch:lib] Split version number from paper identifier #39

Merged

eonu merged 2 commits into master from patch/version-removal

Apr 6, 2019

Owner

eonu commented Apr 6, 2019

Split version number from paper identifier in Paper (add version key-word argument to #id and #url, and add #version).
Change declared regular expression literals from %r"" to standard //.
Add Cleaner.extract_id and Cleaner.extract_version.
Remove #extract_id from Query and use Cleaner.extract_id instead.
Redefine Paper#revision? to use the new #version instead of #updated_at and#published_at.

eonu added 2 commits

April 6, 2019 20:44


          Split version number from identifier

dec00d7


          Change declared regular expression literals

a3c3233

eonu merged commit 730c64d into master

eonu mentioned this pull request

[release] 1.0.0 🎉 (stable) #41

Merged

eonu deleted the patch/version-removal branch

April 8, 2019 16:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment