Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect implementation of predict_log_proba for KNNClassifier #246

Closed
1 task done
eonu opened this issue Apr 2, 2024 · 1 comment
Closed
1 task done

Incorrect implementation of predict_log_proba for KNNClassifier #246

eonu opened this issue Apr 2, 2024 · 1 comment
Assignees
@eonu
Labels
bug Something isn't working

Comments

@eonu
Copy link
Owner

eonu commented Apr 2, 2024

Has this already been reported?

  • This is a new bug!

Expected behaviour

Should be predict_proba not predict_scores.

Observed behaviour

sequentia/sequentia/models/knn/classifier.py

Line 300 in b1aeb60

return np.log(self.predict_scores(X, lengths=lengths))

Code to reproduce

N/A

Version details

N/A
@eonu eonu added the bug Something isn't working label Apr 2, 2024
@eonu eonu self-assigned this Apr 2, 2024
@eonu eonu mentioned this issue Apr 2, 2024
Merged
4 tasks
@eonu
Copy link
Owner Author

eonu commented Apr 2, 2024

Fixed in #247.

@eonu eonu closed this as completed Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eonu eonu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eonu