Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use log probs for KNNClassifier.predict_log_proba #247

Merged
merged 1 commit into from Apr 2, 2024

Conversation

eonu
Copy link
Owner

@eonu eonu commented Apr 2, 2024

Description

Was incorrectly using np.log(self.predict_scores(...)) instead of np.log(self.predict_probs(...)).

Fixes #246.

Checklist

  • I have added new tests (if necessary).
  • I have ensured that tests and coverage are passing on CI.
  • I have updated any relevant documentation (if necessary).
  • I have used a descriptive pull request title.

@eonu eonu changed the title fix: dont use log scores for KNNClassifier.predict_log_proba fix: use log probs for KNNClassifier.predict_log_proba Apr 2, 2024
@coveralls
Copy link

Pull Request Test Coverage Report for Build be2981b0-22b1-442d-a820-3461aa7c2492

Details

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 90.634%

Totals Coverage Status
Change from base Build 2a88cd07-c9dc-446b-b920-fd6bb88ff346: 0.0%
Covered Lines: 2187
Relevant Lines: 2413

💛 - Coveralls

@eonu eonu merged commit d93bab5 into dev Apr 2, 2024
12 checks passed
@eonu eonu deleted the fix-knn-classifier-log-proba branch April 2, 2024 09:09
@github-actions github-actions bot mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants