-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Rector] Check if parent method has doc block in ReturnArrayToYieldRector #13
Merged
roman-eonx
merged 27 commits into
main
from
feature/check-is-parent--method-has-doc-block
Oct 21, 2021
Merged
[Rector] Check if parent method has doc block in ReturnArrayToYieldRector #13
roman-eonx
merged 27 commits into
main
from
feature/check-is-parent--method-has-doc-block
Oct 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alexndlm
commented
Oct 15, 2021
•
edited by roman-eonx
Loading
edited by roman-eonx
- add hasDocBlockInParentMethod check to ReturnArrayToYieldRector
- update tests
alexndlm
requested review from
roman-eonx and
ERuban
and removed request for
ERuban and
roman-eonx
October 15, 2021 18:38
alexndlm
changed the title
feature/check-is-parent--method-has-doc-block
[Rector] Check is parent method has doc block in ReturnArrayToYieldRector
Oct 20, 2021
roman-eonx
approved these changes
Oct 21, 2021
roman-eonx
changed the title
[Rector] Check is parent method has doc block in ReturnArrayToYieldRector
[Rector] Check if parent method has doc block in ReturnArrayToYieldRector
Oct 21, 2021
ERuban
approved these changes
Oct 21, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.