Implemented silent waypoints for Android. #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
eopeter
requested changes
Apr 21, 2023
android/.gitignore
Outdated
| @@ -7,3 +7,4 @@ | |||
| /build | |||
| /captures | |||
| .cxx | |||
| /src/main/res/values/mapbox_access_token.xml | |||
There was a problem hiding this comment.
this file should never exist in the plugin. It is a component of the app that consumes the plugin; so this is not needed
android/src/main/kotlin/com/eopeter/flutter_mapbox_navigation/FlutterMapboxNavigationPlugin.kt
Outdated
Show resolved
Hide resolved
android/src/main/kotlin/com/eopeter/flutter_mapbox_navigation/models/SimpleWaypoint.kt
Outdated
Show resolved
Hide resolved
…ass more flexible and exposes more mapbox functionality but makes the code slightly less intuitive.
eopeter
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented changes so that the 'isSilent' property is respected by the navigation UI.
Silent waypoints are not announced by the navigator.
Waypoints that are not silent have their name announced by the navigator.