Feature/navigation cancelled finished #235
Conversation
|
@marcotrumpet Thanks a lot mate, @eopeter can we get new build with this fix soon ? |
|
@marcotrumpet Not entirely sure about this PR; Why does ending navigation depend on the Feedback? |
ios/Classes/models/Feedback.swift
Outdated
There was a problem hiding this comment.
Why do we need to collect feedback from the user? Mapbox should be prompted to show its Feedback form or prevented from showing it if you do not wish to participate
lib/src/models/feedback.dart
Outdated
There was a problem hiding this comment.
Why do we need to collect feedback from the user? Mapbox should be prompted to show its Feedback form or prevented from showing it if you do not wish to participate
There was a problem hiding this comment.
If I prompt my user a route I want to know if everything was fine. It's not mandatory to use, if you don't care about user feedback you can simply ignore data in your app
There was a problem hiding this comment.
Yes, this seems to be too opinionated and should not be in the library. You can implement it in your Flutter app by hiding MapBox Feedback and providing your own feedback form. It should not be done in the plugin
There was a problem hiding this comment.
Yes, this seems to be too opinionated and should not be in the library. You can implement it in your Flutter app by hiding MapBox Feedback and providing your own feedback form. It should not be done in the plugin
I disagree. It's a mapbox feature so why is this not ok?
By the way your package your roule, feel free to reject this PR
There was a problem hiding this comment.
It's not about my package my rule, it is a community package and we can have civilized discussions about it and come to an agreement. Without contributors, this package will not be where it is today.
I will merge this but I am requesting a change in the PR to make the override of the view optional. Users should opt in.
There was a problem hiding this comment.
Agree with the civilized discussion. This can't happen though if you close issues pointing to PR with bad workaround and about different topic.
I would also suggest to open up the discussion section so we can discuss whether or not follow lint rules and best practices
It does not. It gives you more infos back (rating and comment from the native view) in case you need in flutter app. Main thing here is that now events are received properly on dart side. Previously there were an issue because the enum was index based but the ios enum are different than dart enum |
android/src/main/kotlin/com/eopeter/flutter_mapbox_navigation/activity/NavigationActivity.kt
Show resolved
Hide resolved
Referring to this and this
On iOS, event handling is fixed, now uses enums string instead of int so we can properly get on Dart side instead of relying on index.
When a user ends navigation we get navigation_finished events and also we can collect feedback (rating and comment) in Dart.
On Android, creating a custom InfoPanelEndNavButton (with the same UI) let us override the onTap action, I set it to stop the navigation and send back to dart the navigation_cancelled events.