Is there a specified reason to use sha256 in newRandomPrivateKey?

[nanmu42]

eos-go/ecc/privkey.go

Lines 25 to 40 in fbd70cf

	func newRandomPrivateKey(randSource io.Reader) (*PrivateKey, error) {
	rawPrivKey := make([]byte, 32)
	written, err := io.ReadFull(randSource, rawPrivKey)
	if err != nil {
	return nil, fmt.Errorf("error feeding crypto-rand numbers to seed ephemeral private key: %s", err)
	}
	if written != 32 {
	return nil, fmt.Errorf("couldn't write 32 bytes of randomness to seed ephemeral private key")
	}
	h := sha256.New()
	h.Write(rawPrivKey)
	privKey, _ := btcec.PrivKeyFromBytes(btcec.S256(), h.Sum(nil))
	return &PrivateKey{Curve: CurveK1, privKey: privKey}, nil
	}

Hello, fabulous work, love it. 🚀

Just curious, why not use random bytes directly?

[abourget]

Wow, that's a great question.

It was introduced in 7273b70 which seems unrelated to that change.. seems to have slipped in.

It's pretty much inconsequential, but I took it out. @ellipticasec can you review ae163a3 please ?

[nanmu42]

Thanks for your kind reply, cheers. 🍻