Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add call actions #634

Merged
merged 15 commits into from
Aug 14, 2023
Merged

Add call actions #634

merged 15 commits into from
Aug 14, 2023

Conversation

yarkinwho
Copy link
Contributor

Preliminary implementation of the call function.

Including two actions:
1 call, must be called by some eos account, and will send transaction on behalf of the caller
2 admincall, must be called by the evm account (controlled by multisig e.g.), allow send transaction on behalf of any account. It should only be used by recovery +

pending submodule update

@yarkinwho
Copy link
Contributor Author

resolve #608

@yarkinwho yarkinwho linked an issue Jul 28, 2023 that may be closed by this pull request
Allow admin call to call as reserved address.
@yarkinwho yarkinwho marked this pull request as ready for review July 28, 2023 14:27
@yarkinwho
Copy link
Contributor Author

Fixed some issues, now the call/admincall action can create contracts. admincall can also call as reserved address.

@yarkinwho yarkinwho changed the title Add call actions. Pending submodule silkworm updates. Add call actions Aug 7, 2023
include/evm_runtime/evm_contract.hpp Outdated Show resolved Hide resolved
src/actions.cpp Show resolved Hide resolved
src/actions.cpp Outdated Show resolved Hide resolved
src/actions.cpp Outdated Show resolved Hide resolved
tests/call_tests.cpp Outdated Show resolved Hide resolved
tests/call_tests.cpp Outdated Show resolved Hide resolved
tests/call_tests.cpp Outdated Show resolved Hide resolved
tests/call_tests.cpp Outdated Show resolved Hide resolved
tests/call_tests.cpp Outdated Show resolved Hide resolved
Copy link
Member

@arhag arhag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small change remaining and then also the unit test described in #634 (comment).

src/actions.cpp Outdated Show resolved Hide resolved
@yarkinwho yarkinwho requested a review from arhag August 10, 2023 17:14
src/actions.cpp Outdated Show resolved Hide resolved
src/actions.cpp Outdated Show resolved Hide resolved
src/actions.cpp Outdated Show resolved Hide resolved
@yarkinwho yarkinwho requested a review from elmato August 14, 2023 15:03
@arhag arhag merged commit f1d9f9f into main Aug 14, 2023
3 checks passed
@arhag arhag deleted the yarkin/call_action_new branch August 14, 2023 19:19
@arhag arhag mentioned this pull request Aug 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add call action
3 participants