Rework signal handling

[oschwaldp-oci]

Rework signal handling to handle transactions as they are received

Currently, transactions are accumulated till the block state is accepted and the accumulated transactions are sent along with the block state to be handled. This is a problem because when a user calls the send_transaction api, it will take till the speculative block is aborted and the next block is applied before all the transactions are then recorded. This means that if the user tries to immediately get the status of the transaction, it will get back “UNKNOWN” till the transaction is finally processed (up to 500 ms later).

Integration test work

Added integration tests to verify calls to get_transaction_status for a known transaction progressed from "APPLIED_LOCALLY" to "IN_BLOCK" to "IRREVERSIBLE" and then, after passing the success duration, returning "UNKNOWN". Also added a test to verify that get_transaction_status reported the correct status when a transaction's block was forked out.

Issue Resolution

Also resolves Issue: #176

curl -sd '{"id": "240ed958f05b672f9d15bdb332a49fa9e53715ec18272649b951d8f91bfb23e7"}' http://localhost:8888/v1/chain/get_transaction_status | jq
{
  "state": "IN_BLOCK",
  "block_number": 84,
  "block_id": "0000005492ae08787b46c6cc07852fc9391be887dd79e980bcd9245a574c9f56",
  "block_timestamp": "2022-05-06T15:34:17.500",
  "expiration": "2022-05-06T15:34:47.000",
  "head_number": 326,
  "head_id": "00000146f7df7ece3967526f35bcafcf5ae090fbfca208910f20eab73a03efa6",
  "head_timestamp": "2022-05-06T15:36:18.500",
  "irreversible_number": 23,
  "irreversible_id": "0000001727b6d94facf760a323a943ccfe9249224fecce23c402c1f66d09df20",
  "irreversible_timestamp": "2022-05-06T15:33:47.000",
  "earliest_tracked_block_id": "000000110b2a85d157470bfbba56802db4bbad616c0959027d27bd18cdb0d9f1",
  "earliest_tracked_block_number": 17
}

curl -sd '{"id": "00"}' http://localhost:8888/v1/chain/get_transaction_status | jq
{
  "code": 400,
  "message": "Invalid Request",
  "error": {
    "code": 3200006,
    "name": "invalid_http_request",
    "what": "invalid http request",
    "details": [
      {
        "message": "Invalid transaction id",
        "file": "chain_api_plugin.cpp",
        "line_number": 62,
        "method": "parse_params<eosio::chain_apis::read_only::get_transaction_status_params>"
      }
    ]
  }
}

curl -sd '' http://localhost:8888/v1/chain/get_transaction_status | jq
{
  "code": 400,
  "message": "Invalid Request",
  "error": {
    "code": 3200006,
    "name": "invalid_http_request",
    "what": "invalid http request",
    "details": [
      {
        "message": "A Request body is required",
        "file": "chain_api_plugin.cpp",
        "line_number": 54,
        "method": "parse_params<eosio::chain_apis::read_only::get_transaction_status_params>"
      }
    ]
  }
}

[jgiszczak]

Submitting review prematurely because Github has decided to stop displaying my comments in line, for some reason.

I did stop calling out all individual instances of strings which should be converted to f-strings, and also stopped calling out individual instances of assert being used incorrectly. All such changes should still be made.

[jgiszczak]

It may give sufficient time, assuming the efficiency of net_plugin doesn't considerably improve.

We should probably come up with a way to label tests like this which are non-deterministic to tell us where to look first if automated tests get flaky in the future.