[3.2] fixing compile warnings in cleos main.cpp

[linh2931]

Resolved #619

Fixed the following warnings. Now cleos main.cpp compiles without any warnings.

.../programs/cleos/main.cpp: In function ‘fc::variant push_transaction(eosio::chain::signed_transaction&, const std::vector<fc::crypto::public_key>&)’:
.../programs/cleos/main.cpp:503:112: warning: ‘static void eosio::chain::abi_serializer::to_variant(const T&, fc::variant&, Resolver, const fc::microseconds&) [with T = eosio::chain::signed_transaction; Resolver = <lambda(const eosio::chain::name&)>]’ is deprecated: use the overload with yield_function_t[=create_yield_function(max_serialization_time)] [-Wdeprecated-declarations]
  503 |             abi_serializer::to_variant(trx, unpacked_data_trx, abi_serializer_resolver, abi_serializer_max_time);
      |                                                                                                                ^
In file included from .../libraries/chain/include/eosio/chain/controller.hpp:9,
                 from .../plugins/chain_plugin/include/eosio/chain_plugin/chain_plugin.hpp:7,
                 from .../programs/cleos/main.cpp:83:
.../libraries/chain/include/eosio/chain/abi_serializer.hpp:947:6: note: declared here
  947 | void abi_serializer::to_variant( const T& o, fc::variant& vo, Resolver resolver, const fc::microseconds& max_serialization_time ) {
      |      ^~~~~~~~~~~~~~
.../programs/cleos/main.cpp:503:112: warning: ‘static void eosio::chain::abi_serializer::to_variant(const T&, fc::variant&, Resolver, const fc::microseconds&) [with T = eosio::chain::signed_transaction; Resolver = <lambda(const eosio::chain::name&)>]’ is deprecated: use the overload with yield_function_t[=create_yield_function(max_serialization_time)] [-Wdeprecated-declarations]
  503 |             abi_serializer::to_variant(trx, unpacked_data_trx, abi_serializer_resolver, abi_serializer_max_time);
      |                                                                                                                ^
In file included from /.../libraries/chain/include/eosio/chain/controller.hpp:9,
                 from .../plugins/chain_plugin/include/eosio/chain_plugin/chain_plugin.hpp:7,
                 from .../programs/cleos/main.cpp:83:
.../libraries/chain/include/eosio/chain/abi_serializer.hpp:947:6: note: declared here
  947 | void abi_serializer::to_variant( const T& o, fc::variant& vo, Resolver resolver, const fc::microseconds& max_serialization_time ) {
      |      ^~~~~~~~~~~~~~
.../programs/cleos/main.cpp: In function ‘int main(int, char**)’:
.../programs/cleos/main.cpp:3178:9: warning: variable ‘getSchedule’ set but not used [-Wunused-but-set-variable]
 3178 |    auto getSchedule = get_schedule_subcommand{get};
      |         ^~~~~~~~~~~
.../programs/cleos/main.cpp: In function ‘eosio::chain::packed_transaction::compression_type to_compression_type(tx_compression_type)’:
.../programs/cleos/main.cpp:216:1: warning: control reaches end of non-void function [-Wreturn-type]
  216 | }
      | ^

[spoonincode]

Will removal of get_schedule_subcommand{get} eliminate the get schedule command entirely? It seems like maybe only the auto getSchedule = should be removed?

[linh2931]

Thanks, you are correct. Added get_schedule_subcommand{get}; back.