[3.2] Add chain api get_consensus_parameters #692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heifner
suggested changes
Jul 18, 2022
| get_consensus_parameters_results results; | ||
|
|
||
| results.chain_config = db.get_global_properties().configuration; | ||
| results.kv_database_config = db.get_global_properties().kv_configuration; |
There was a problem hiding this comment.
Remove this line. kv_configuration should not exist in Mandel and needs to be removed (or repurposed in the future).
There was a problem hiding this comment.
It's already in mandel ever since #8. Should an issue be made for its removal?
There was a problem hiding this comment.
| using get_consensus_parameters_params = empty; | ||
| struct get_consensus_parameters_results { | ||
| chain::chain_config chain_config; | ||
| chain::kv_database_config kv_database_config; |
There was a problem hiding this comment.
Remove this line and also from the FC_REFLECT
heifner
approved these changes
Jul 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #453