Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.1] remove broad 'using namespace boost' causing float128_t conflict; fixes builds w/ boost 1.80 #702

Merged
merged 1 commit into from
Jul 20, 2022

Conversation

spoonincode
Copy link
Member

abi_serializer.cpp does a

using namespace boost;

Apparently something internal to boost has been reorganized and when building with boost 1.80 beta it appears this pack_unpack<float128_t>() is getting confused with boost::float128_t (gets a template argument deduction/substitution failed error).

Remove the broad using namespace boost to eliminate the conflict. This is arguably a cleaner short term spot fix than #638. If accepted I will open a ticket for a more broad fix across the code base in 3.2 (likely via a softfloat namespace or such)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants