Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add signature option to bp.json #10

Closed
systemzax opened this issue Jun 16, 2018 · 2 comments
Closed

Add signature option to bp.json #10

systemzax opened this issue Jun 16, 2018 · 2 comments

Comments

@systemzax
Copy link

Related to #7

If we allow qualification of the producer public_key as suggested in #7 , we would make it practical to also include an optional signature field to the file to attest authenticity.

The json representation should be stringified in a canonical / deterministic manner, then signed with the private key associated to the account with active permission.

This would make the standard more solid and protect against spoofing, impersonation, phishing attacks, etc... as people will start relying on them more and more.

@lukestokes
Copy link

Since the bp.json is served from a block producer's own website which is signed vis SSL, is a signature really needed?

@igorls
Copy link
Member

igorls commented Sep 19, 2020

we considering adding a optional signature field (this would require some specification on how to sign it), @lukestokes @systemzax do you guys believe this is still an issue? although updating the bp.json on-chain is possible, there are some use cases where is not as practical as the web version

my main worry is about possible vulnerabilities on servers hosting the website (which are usually less secure than other infra), adding the signature would definitely prevent against takeovers

@igorls igorls closed this as completed May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants