Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullerene and 3D molecules are not represented as 3D in the Miew 3D window #1944

Closed
baranovdv opened this issue May 7, 2024 · 7 comments · Fixed by #1971
Closed

Fullerene and 3D molecules are not represented as 3D in the Miew 3D window #1944

baranovdv opened this issue May 7, 2024 · 7 comments · Fixed by #1971
Assignees
Labels
CDX-ChemDraw Bucket: Save/View/Open of CDX forrmat related issues Feature Priority: Medium

Comments

@baranovdv
Copy link

baranovdv commented May 7, 2024

Steps to Reproduce

  1. Open CDX file from ChemDraw (Fullerene and 3D molecules)
    image

  2. Ketcher Mview
    image

Actual behavior
Fullerene and 3D molecules are not represented as 3D in the Miew 3D window.
Kindly see pictures.
Task epam/ketcher#4232

Expected behavior
Fullerene and 3D molecules should be represented as 3D in the Miew 3D window.

Attachments
FullereneCDX-example.zip

Related:

Environment details:
• OS: Windows 10 Pro (version 22H2) x64
• Browser: Сhrome
• Version: (122.0.6261.95) x64

Ketcher version 2.19.0 – rc.2
Indigo Toolkit
Version 1.18.0-rc.6.0-g98bf384e0-x86_64-linux-gnu-11.2.1

Additional context:
When converting from .cdx to .ket Indigo should return atoms with correct z-coordinate

@AlexeyGirin
Copy link
Collaborator

See epam/ketcher#4291 for extra details (in comments)

@gilvan-fernandes
Copy link

Hello

My team is considering Ketcher, and this fix would add up a lot to make our case convincing our stakeholders. Is there a prediction about when this will be available? At least in a release candidate?

@rrodionov91
Copy link
Collaborator

Hi @gilvan-fernandes

Thank you for feedback.

It was fixed on Ketcher side in this ticket epam/ketcher#3501 in 2.22.0-rc.2. We are going to make public release 2.22.0 soon, however you can use 2.22.0-rc.9, it is stable.

@gilvan-fernandes
Copy link

Thank you for the fast response!

@rrodionov91
Copy link
Collaborator

rrodionov91 commented Jul 26, 2024

Z coordinate in KET format fixed on Ketcher side in epam/ketcher#3501
However it is removed after CDX/CDXML conversion by indigo.
@gilvan-fernandes it works for KET, MOL V2000, MOL V3000 formats, but not for CDX/CDXML. Fix for it planned in Indigo 1.23.0-rc.1 (Ketcher 2.24.0-rc.1)

@rrodionov91 rrodionov91 closed this as not planned Won't fix, can't repro, duplicate, stale Jul 26, 2024
@rrodionov91 rrodionov91 reopened this Jul 26, 2024
@rrodionov91 rrodionov91 assigned even1024 and unassigned NayanaGadakh Jul 26, 2024
even1024 added a commit that referenced this issue Jul 29, 2024
…w 3D window (#1971)

Co-authored-by: Roman Porozhnetov <roman_porozhnetov@epam.com>
@AlexeyGirin
Copy link
Collaborator

No fixed.
Still flat.
image

  • Ketcher Version 2.23.0-rc.3 Build at 2024-07-31; 05:31:01
  • Indigo Toolkit Version 1.23.0-dev.2.1-gd93b8ec4-wasm32-wasm-clang-12.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.89 (Official Build) (64-bit)

@AlexeyGirin AlexeyGirin reopened this Aug 2, 2024
@AlexeyGirin
Copy link
Collaborator

Fixed.
Provided cdx doesn't contain z-coordinates and ChemDraw uses it's own capabilities to create them from the scratch.
I created my own cdx (3d structures example.zip) with z-coordinates in place and it works correct in both - ChemDraw and Ketcher
image

  • Ketcher Version 2.23.0-rc.3 Build at 2024-07-31; 05:31:01
  • Indigo Toolkit Version 1.23.0-dev.2.1-gd93b8ec4-wasm32-wasm-clang-12.0.0
  • Windows 10 Pro
  • Chrome Version 127.0.6533.89 (Official Build) (64-bit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CDX-ChemDraw Bucket: Save/View/Open of CDX forrmat related issues Feature Priority: Medium
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

6 participants