Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1944-Fullerene and 3D molecules are not represented as 3D in the Miew 3D window #1971

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

#1944-Fullerene and 3D molecules are not represented as 3D in the Miew 3D window #1971

wants to merge 8 commits into from

Conversation

NayanaGadakh
Copy link
Collaborator

Generic request

  • [✓] PR name follows the pattern #1234 – issue name
  • [✓] branch name does not contain '#'
  • [✓] base branch (master or release/xx) is correct
  • [✓] PR is linked with the issue
  • [✓] task status changed to "Code review"
  • [✓] code follows product standards
  • [✓] regression tests updated

@NayanaGadakh NayanaGadakh linked an issue May 27, 2024 that may be closed by this pull request
Fullerene and 3D molecules are not represented as 3D in the Miew 3D window #1944
Open
@NayanaGadakh NayanaGadakh removed the request for review from even1024 May 27, 2024 12:26
even1024
even1024 reviewed May 27, 2024
View reviewed changes
core/indigo-core/molecule/src/molecule_cdxml_loader.cpp
Copy link
Collaborator

@even1024 even1024 May 27, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This field should be added to parseNode, not to parseText. You don't have cdxml to mol test which would reveal the issue.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In parseNode, both p and xyz are already present. {"p", pos_lambda},{"xyz", pos_lambda},
I have made changes in parsePos to handle z coord.

even1024
even1024 reviewed May 27, 2024
View reviewed changes
core/indigo-core/molecule/src/molecule_cdxml_saver.cpp
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6 copy-pastes?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed unnecessary copies where z coord is not required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@even1024 even1024 Awaiting requested review from even1024

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fullerene and 3D molecules are not represented as 3D in the Miew 3D window
2 participants
@NayanaGadakh @even1024