Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Permission check fixes, pipeline fixes, crash fixes #251

Merged
merged 1 commit into from
May 27, 2024

Conversation

callmevladik
Copy link
Contributor

Pull Request Template

Description

  • Fix permissions check related issues
  • Fix registry form registry endpoint field value form sync issues
  • Fix crashes in pipeline page
  • Fix delete button logic in deploy flow
  • Fix pipelines page crash when trying to filter by labels

Fixes #249

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Pull Request contain one commit. I squash my commits.

@callmevladik callmevladik added the bug Something isn't working label May 27, 2024
@callmevladik callmevladik self-assigned this May 27, 2024
@callmevladik callmevladik requested a review from a team as a code owner May 27, 2024 13:56
@NikolayMarusenko
Copy link
Contributor

/recheck

@callmevladik callmevladik merged commit e8c72ed into master May 27, 2024
6 checks passed
@callmevladik callmevladik deleted the fix/pipeline-fixes branch May 27, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

Add permissions check for actions
3 participants