Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error if secret created and owned by keycloakclient is deleted before it #62

Closed
mostoja opened this issue May 21, 2024 · 5 comments · Fixed by #70
Closed

Error if secret created and owned by keycloakclient is deleted before it #62

mostoja opened this issue May 21, 2024 · 5 comments · Fixed by #70
Assignees
Labels
bug Something isn't working

Comments

@mostoja
Copy link

mostoja commented May 21, 2024

Describe the bug
If during deletion of keycloakclient's namespace secret owned by resource is deleted before resource I get an unable to serve keycloak client error and resource is never deleted

To Reproduce

What did you do?

Tried deleting keycloakclient's namespace

What did you expect to see?

Namespace deleted

What did you see instead? Under which circumstances?

Deletion hanging becuase keycloakclient's finalizer is not removed

Kubernetes cluster type:

AKS

$ operator-sdk version

$ go version

$ kubectl version

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

@NikolayMarusenko NikolayMarusenko added the bug Something isn't working label May 21, 2024
@zmotso
Copy link
Contributor

zmotso commented May 21, 2024

Hi @mostoja. Thank you for your feedback.
We plan to fix this issue.
Currently, a workaround for this problem may be to use foreground deletion.
Example:
kubectl delete ... --cascade=foreground

zmotso added a commit that referenced this issue Jun 25, 2024
Moved the deletion process of the KeycloakClient
before any logic that requires client secrets.
This will help avoid errors if the KeycloakClient secret
is removed before it and the deletion process gets stuck.
NikolayMarusenko pushed a commit that referenced this issue Jun 25, 2024
Moved the deletion process of the KeycloakClient
before any logic that requires client secrets.
This will help avoid errors if the KeycloakClient secret
is removed before it and the deletion process gets stuck.
@mostoja
Copy link
Author

mostoja commented Jun 27, 2024

lovely! can we expect new release and helm chart soon?

@FWest98
Copy link

FWest98 commented Jul 20, 2024

I am also experiencing this issue. When can we expect a new release?

@NikolayMarusenko
Copy link
Contributor

This component will be released soon. You can track its progress here: #76.

@NikolayMarusenko
Copy link
Contributor

@mostoja @FWest98 keycloak-operator version 1.22 has been released with the latest fixes and improvements: https://github.com/epam/edp-keycloak-operator/releases/tag/v1.22.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging a pull request may close this issue.

4 participants