Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add imagePullSecrets to enable private repository #51

Merged
merged 1 commit into from
May 7, 2024

Conversation

Bengreen
Copy link
Contributor

@Bengreen Bengreen commented May 4, 2024

Pull Request Template

Description

When deployment in many environments the images are provided via a private repository.
Private repository's require imagePullSecrets.
This PR adds imagePullSecrets to the values file of the chart AND uses it to provide the imagePullSecrets to the deployment.
If no secrets are provided (default) the imagePullSecrets is not applied to the deployment.

Fixes # (issue)

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Pull Request contain one commit. I squash my commits

Screenshots (if appropriate):

Additional context

Add any other context or screenshots about the feature request here.

@Bengreen Bengreen changed the title Add imagePullSecrets to enable private repository feature: Add imagePullSecrets to enable private repository May 4, 2024
Copy link

@Arania Arania left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Would be a good addition as this is a common use case.

@SergK
Copy link
Member

SergK commented May 7, 2024

Hi @Bengreen, can you please run:

  1. 'make helm-docs',
  2. rebase on the latest changes from master
  3. fix the commit message by setting 'feat' instead of 'feature'

Thank you

@Bengreen
Copy link
Contributor Author

Bengreen commented May 7, 2024

@SergK I have rebased, run make helm-docs and then updated the PR branch.

Copy link
Member

@SergK SergK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bengreen Thank you

@SergK SergK merged commit 1844721 into epam:master May 7, 2024
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants