Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When User open .mol file with R-Group and then try to save it - blank page appears #187

Closed
KseniiaSemenishcheva opened this issue Dec 17, 2020 · 2 comments · Fixed by #227
Closed

When User open .mol file with R-Group and then try to save it - blank page appears #187

KseniiaSemenishcheva opened this issue Dec 17, 2020 · 2 comments · Fixed by #227
Assignees
@AndreiMazol @KseniiaSemenishcheva
Labels
bug Priority: High
Projects
Ketcher

Comments

@KseniiaSemenishcheva
Copy link

KseniiaSemenishcheva commented Dec 17, 2020 •
edited

Steps to Reproduce:

  1. Create structure with R-Groups like in example:
    Screenshot 2020-12-17 145336
  2. Click "Save As..." and save as .mol file "Rgroup.mol".
  3. Clean canvas.
  4. Open "Rgroup.mol" in Ketcher. Rgroup.zip
  5. Click "Save As..." button.

Expected Result:
"Save As.." modal window appears.

Actual Result:
Blank page and error in console appear:
Screenshot 2020-12-17 134854
@AndreiMazol AndreiMazol self-assigned this Dec 28, 2020
@AndreiMazol AndreiMazol added this to In progress in Ketcher Dec 28, 2020
@AndreiMazol
Copy link
Contributor

@KseniiaSemenishcheva I cannot reproduce the issue.

rgroup_187.zip has been used for testing.

@AndreiMazol AndreiMazol moved this from In progress to Ready for testing in Ketcher Dec 28, 2020
@KseniiaSemenishcheva KseniiaSemenishcheva removed their assignment Dec 29, 2020
@AndreiMazol AndreiMazol moved this from Ready for testing to In progress in Ketcher Dec 29, 2020
AndreiMazol added a commit that referenced this issue Dec 29, 2020
@AndreiMazol
#187 Blank page appears while saving file with R-group
ff87b1e 
- fix isAbs function
@AndreiMazol AndreiMazol linked a pull request Dec 29, 2020 that will close this issue
#187 Blank page appears while saving file with R-group #227
Merged
AndreiMazol added a commit that referenced this issue Dec 29, 2020
@AndreiMazol
#187 Blank page appears while saving file with R-group (#227)
de942b3 
- fix isAbs function
@AndreiMazol AndreiMazol moved this from In progress to Ready for testing in Ketcher Dec 29, 2020
@KseniiaSemenishcheva KseniiaSemenishcheva self-assigned this Dec 29, 2020
@KseniiaSemenishcheva KseniiaSemenishcheva moved this from Ready for testing to In testing in Ketcher Dec 29, 2020
@KseniiaSemenishcheva
Copy link
Author

Issue is closed as fixed.

@KseniiaSemenishcheva KseniiaSemenishcheva moved this from In testing to Done in Ketcher Dec 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreiMazol AndreiMazol

@KseniiaSemenishcheva KseniiaSemenishcheva

Labels
bug Priority: High
Projects
Ketcher
  
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#187 Blank page appears while saving file with R-group epam/ketcher
2 participants
@AndreiMazol @KseniiaSemenishcheva