Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Settings' - It's not convenient to change the default colors of the stereogenic centers by typing RGB colors #521

Closed
Svetlana-Asinovskaia opened this issue May 19, 2021 · 1 comment · Fixed by #751
Closed

'Settings' - It's not convenient to change the default colors of the stereogenic centers by typing RGB colors #521

Svetlana-Asinovskaia opened this issue May 19, 2021 · 1 comment · Fixed by #751
Assignees
@AndreiMazol @r1z3rISGOD
Labels
bug Priority: Low
Projects
Ketcher
Milestone
Release 2.4.0

Comments

@Svetlana-Asinovskaia
Copy link
Collaborator

Tested on Ketcher v2.2.1-104-gc7896113

Steps to reproduce:

  1. Launch Ketcher.
  2. Click the 'Settings' button
  3. Change the default settings for any stereogenic center (e.g. "Color of Absolute Center") by typing the parameters of RGB color (e.g. 146, 201, 178)

Expected result: It's easy to specify the parameters of an RGB color value.
Actual result: If the zero value of one of the parameters is cleared before entering a new value, all other parameters are also set to zero.
2021-05-19_14h55_22
@Svetlana-Asinovskaia Svetlana-Asinovskaia added bug external Issue depends on external services such as Indigo service Priority: Low labels May 19, 2021
@Svetlana-Asinovskaia Svetlana-Asinovskaia added this to the Backlog milestone May 19, 2021
@AndreiMazol AndreiMazol removed the external Issue depends on external services such as Indigo service label May 26, 2021
@r1z3rISGOD r1z3rISGOD self-assigned this Sep 8, 2021
@r1z3rISGOD r1z3rISGOD added this to In progress in Ketcher Sep 8, 2021
@r1z3rISGOD r1z3rISGOD linked a pull request Sep 9, 2021 that will close this issue
#521 not convient to change color #751
Merged
@r1z3rISGOD r1z3rISGOD moved this from In progress to Code review in Ketcher Sep 9, 2021
AndreiMazol pushed a commit that referenced this issue Sep 9, 2021
@r1z3rISGOD
#521 not convient to change color (#751)
8255b56 
* fix not convient to change color by change package

* Change picker style

* Repair tests

* Move color picker package to ketcher-react

Co-authored-by: Kirill Kapytov <kirill_kapytov@epam.com>
@AndreiMazol AndreiMazol moved this from Code review to Ready for testing in Ketcher Sep 9, 2021
@AndreiMazol AndreiMazol modified the milestones: Backlog, Release 2.4.0 Sep 9, 2021
@AndreiMazol AndreiMazol self-assigned this Sep 9, 2021
@vitalgerko vitalgerko moved this from Ready for testing to In testing in Ketcher Sep 15, 2021
@vitalgerko vitalgerko moved this from In testing to Done in Ketcher Sep 16, 2021
@vitalgerko
Copy link

Release/2.4 Closed as fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreiMazol AndreiMazol

@r1z3rISGOD r1z3rISGOD

Labels
bug Priority: Low
Projects
Ketcher
  
Done
Milestone
Release 2.4.0
Development

Successfully merging a pull request may close this issue.

#521 not convient to change color epam/ketcher
4 participants
@AndreiMazol @r1z3rISGOD @Svetlana-Asinovskaia @vitalgerko