Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#3501 - 3d mol files appear as 2D in Miew #4529

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

mtreinik
Copy link
Contributor

@mtreinik mtreinik commented Apr 24, 2024

Fix viewing 3D molecules in Miew (issue #3501)

  • Rotation was missing z coordinate when switching into chemistry coordinate system.

How the feature works? / How did you fix the issue?

(Screenshots, videos, or GIFs, if applicable)

Check list

  • unit-tests written
  • e2e-tests written
  • documentation updated
  • PR name follows the pattern #1234 – issue name
  • branch name doesn't contain '#'
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • task status changed to "Code review"
  • reviewers are notified about the pull request

- Rotation was missing z coordinate when switching into chemistry coordinate system.
@mtreinik mtreinik removed their assignment Apr 24, 2024
@mtreinik mtreinik changed the title Fix viewing 3D molecules in Miew (issue #3501) #3501 3d mol files appear as 2D in Miew Apr 24, 2024
@mtreinik
Copy link
Contributor Author

Sorry, the PR name did not follow the required pattern, and I don't know how to link the PR to the issue #3501. I also accidentally unassigned myself from the PR and don't seem to be able to assign myself back to it.

@NataliaLoginova
Copy link
Collaborator

@mtreinik thank you a lot for for fixing the issue #3501!

@NataliaLoginova NataliaLoginova merged commit 0dc44a1 into epam:master Apr 25, 2024
5 checks passed
@rrodionov91 rrodionov91 linked an issue Apr 26, 2024 that may be closed by this pull request
@rrodionov91 rrodionov91 changed the title #3501 3d mol files appear as 2D in Miew #3501 - 3d mol files appear as 2D in Miew Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3d mol files appear as 2D in Miew
2 participants