Restore coverage publishing #516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
February 20, 2024 17:37
- now we send report using coveralls app
paulsmirnov
reviewed
Feb 22, 2024
There was a problem hiding this comment.
Great job! I see the results at https://coveralls.io/jobs/136529785
Could you please check if we need to address my comments?
.github/workflows/ci.yml
Outdated
| run: yarn run merge-cover | ||
|
|
||
| - name: Coveralls | ||
| if: matrix.node == '20' |
There was a problem hiding this comment.
The CI script runs twice, on push and PR. It uploads the coverage twice. Could we do it only once, on push?
There was a problem hiding this comment.
Good catch 😉
I limited publishing only for 'push' event.
NataliaDSmirnova
changed the title
NataliaDSmirnova
changed the title
added 2 commits
February 21, 2024 20:32
NataliaDSmirnova
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
coverallspackage because publication is done via application (note :coverallsremoving fixesjson-schemavulnerability https://github.com/epam/miew/security/dependabot/114)lcov-result-merger,mkdirp,rimrafType of changes
Checklist
yarn run ci: lint and tests pass locally with my changes.