Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose CSVDataWriterImpl.processEntry for other output uses #24

Closed
Gagravarr opened this issue Jan 2, 2018 · 4 comments
Closed

Expose CSVDataWriterImpl.processEntry for other output uses #24

Gagravarr opened this issue Jan 2, 2018 · 4 comments

Comments

@Gagravarr
Copy link

Once #19 is done, we'd like to make use of Parso to provide a SAS7BDAT parser for Apache Tika (see TIKA-2462). In that parser, we'll want to get the "formatted" value as a string for each cell, then output that as SAX events for a HTML table

Currently, it seems that all the logic for turning column metadata + column number + raw value into a formatted string is hidden inside CSVDataWriterImpl, especially CSVDataWriterImpl.processEntry

It would be great if the logic for formatting as a string could be made available for re-use! Maybe by pulling it out to a helper class that CSVDataWriterImpl then uses?

@printsev
Copy link
Contributor

Hi @Gagravarr, could you please check master branch? is this what you have expected?

@Gagravarr
Copy link
Author

Looks like DataWriterUtil.getRowValues should give us what we need for Tika, thanks!

Once there's a 2.0.9 we can go ahead and add the parser :)

@printsev
Copy link
Contributor

2.0.9 is available in maven central so I'm closing the issue now. Please reopen if you need some assistance.

@Gagravarr
Copy link
Author

I've now integrated this with Apache Tika, and everything worked great, thanks!

It'll be included in Tika 1.19 (or 2.0 if we get that out first...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants