[ Support for declarations in (call, if, scatter & while) blocks ]

* Coverage increased
epam · Mar 12, 2018 · cbb1d57 · cbb1d57
1 parent a953956
commit cbb1d57
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/model/Group.js b/src/model/Group.js
@@ -65,7 +65,7 @@ class Group extends Step {
         root.declarations[declaration.name] = declaration;
       }
       this.ownDeclarations[declaration.name] = declaration;
-    } else if ((existingInRoot && existingInRoot !== declaration) || ownExisting !== declaration) {
+    } else if (existingInRoot !== declaration && ownExisting !== declaration) {
       throw new Error(`Cannot add a declaration with the same name ${declaration.name}.`);
     }
     return declaration;

diff --git a/test/parser/parseTest.js b/test/parser/parseTest.js
@@ -65,8 +65,11 @@ workflow RootWorkflow {
         resolve(data);
       }
     });
-  }).then(data => parse(wdl, { zipFile: data, subWfDetailing: '*', recursionDepth: 10 }))).to.be.fulfilled);
+  }).then(data => parse(wdl, { zipFile: data, subWfDetailing: ['*'], recursionDepth: 10 }))).to.be.fulfilled);
 
   it('returns with error if source zip is incorrect', () =>
     expect(parse(wdl, { zipFile: 'test' })).to.be.rejectedWith('Error'));
+
+  it('returns with error if no wdl presented', () =>
+    expect(parse('')).to.be.rejected);
 });