New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allowing declarations to be placed after other things of current scope #48
Conversation
…or: Undeclared call is referenced: 'Utils_ConvertToCram'" when calling 'call ns.name as name'
* added Declaration instance to model * knowing inputs & declarations apart * declarations in blocks aren't causing app to crash
* added VisualDeclaration instance * visualization for Declarations was added to Visualizer * added links expression types like 'FunctionCall', 'ArrayOrMapLookup', 'ArrayLiteral' and so on * changed links type
* fixed eslint error 'class-method-use-this'
* WDLWorkflow tests were added
* Group tests were added
* Declaration tests were added
* Coverage increased
* the imports resolving feature was updated according to the new declarations
* tests added for renaming_utils.js
PNG button doesn't work22491d0
Expected result: picture of the scheme below is downloaded Comments: |
UpdateThis behaviour is expected Unexpected task name is displayed22491d0
Expected result: "if" block has name "myOtherWorkflow" Comments: You can observe it if use this script |
* coverage increased
[Fixed] Console error if user build script8e9fb41
|
* Fixed console error found in the PR
* coverage increased
…(e.g. scatter, if, etc.)
An Issue
There are some scripts featured in production that use
Declarations
afterCalls
or other things of current scope. It causespipeline-builder
to throw an Error (Context initialization failed due to WDLParserError: Declarations are allowed only before other things of current scope
).This PR resolves this issue.