Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added some functionality to the API #12

Merged
merged 4 commits into from Nov 20, 2012
Merged

Conversation

thorstent
Copy link
Contributor

Please review and approve. Thanks.

fixed access to library in Windows (still use / to navigate into jar files)
better printing support by getting more information with the getters
Basic support for tactics and solvers (allows us to work with quantifiers)
@psuter
Copy link
Member

psuter commented Nov 3, 2012

Hi Thorstent,

thanks for the patches, they're very welcome. I see that this pull request is an extension of the one you closed? I was actually trying that out yesterday and my local copy of Z3 kept crashing. It's extremely unlikely to be related to your changes, which seem perfectly fine, but I'd like to find the root of the problem before I merge anyway.

@psuter psuter closed this Nov 3, 2012
@psuter psuter reopened this Nov 3, 2012
@thorstent
Copy link
Contributor Author

Hey,

My test env is windows. I build the latest branch of Z3 manually in VS2012 and compile ScalaZ3 against that. Please have a look at this pull request, it works for me.

The main thing that bugs me about these functional additions is that they are not complete, only those functions i absolutely need for my current work. Anyhow, if everyone adds what he needs we'll get closer.

Btw. you can create a solver like this and it'll magically start solving quantifiers it wouldn't solve earlier:
val tactic1 = z3.mkTactic("qe")
val tactic2 = z3.mkTactic("smt")
tactic = z3.mkTacticAndThen(tactic1, tactic2)
tactic1.delete()
tactic2.delete()
solver = z3.mkSolverFromTactic(tactic)

psuter added a commit that referenced this pull request Nov 20, 2012
Added some functionality to the API
@psuter psuter merged commit 36de360 into epfl-lara:master Nov 20, 2012
@psuter
Copy link
Member

psuter commented Nov 20, 2012

Thanks again!

@ghost ghost assigned psuter Nov 20, 2012
@psuter
Copy link
Member

psuter commented Nov 20, 2012

(Also note that I reverted the hardcoding of LIB_SEPARATOR = "/" in a subsequent commit. If you need this, I'd be curious to know why.)

@thorstent
Copy link
Contributor Author

There is a reason for that: First of all the / works fine on windows. But the \ won't work for getResourceAsStream (line 84).

@psuter
Copy link
Member

psuter commented Nov 20, 2012

I see, jar resources are accessed uniformly across platforms. That makes sense. Reverted my revert. Thanks.

@vo1stv
Copy link
Contributor

vo1stv commented Nov 25, 2012

Sounds good. I guess the tip at the bottom of http://www.inonit.com/cygwin/jni/helloWorld/load.html is confirmed and recommended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants