Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement @samarion's fix for issue 115 with lambda pointers #135

Merged
merged 3 commits into from
Apr 20, 2021
Merged

Implement @samarion's fix for issue 115 with lambda pointers #135

merged 3 commits into from
Apr 20, 2021

Conversation

jad-hamza
Copy link
Contributor

@jad-hamza jad-hamza commented Apr 20, 2021 •
edited
Loading

Fix issue #115

samarion
samarion reviewed Apr 20, 2021
View reviewed changes
Copy link
Member

@samarion samarion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Could you also please add the broken example from the issue as a testcase?

src/main/scala/inox/solvers/unrolling/Templates.scala Outdated
case adt @ ADT(id, tps, es) => (adt.getConstructor.fields zip es).flatMap {
case (vd, e) => collectSelectors(e, ADTSelector(ptr, vd.id))
}
def collectSelectors(expr: Expr, ptr: Expr): Seq[(Expr, Variable)] = expr match {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: make it private?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! resultPointers as well?

@jad-hamza
Copy link
Contributor Author

Thanks for the fix! Could you also please add the broken example from the issue as a testcase?

Thanks for writing the fix :) I've added the example

@samarion samarion merged commit 6bcf926 into epfl-lara:master Apr 20, 2021
@jad-hamza jad-hamza mentioned this pull request Apr 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samarion samarion samarion left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jad-hamza @samarion