Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preserve class annotations in Leon's AST #132

Closed
wants to merge 2 commits into from
Closed

preserve class annotations in Leon's AST #132

wants to merge 2 commits into from

Conversation

larsrh
Copy link
Contributor

@larsrh larsrh commented Sep 2, 2015

Follow-up to 3e4281d. Uses mutable state to imitate similar other properties of ClassDefs.

Follow-up to 3e4281d. Uses mutable state to imitate similar other
properties of ClassDefs.
@manoskouk
Copy link
Member

Why do you need this? In my opinion, it seems more elegant to have a specific class that captures the functionality we want, as in FunDef, rather than a Map[String, Seq[Option[Any]]]. Unless you really need the general case.

@larsrh
Copy link
Contributor Author

larsrh commented Sep 3, 2015

You mean like FunctionFlag, or just giving a dedicated type to (String, Seq[Option[Any]])?

@manoskouk
Copy link
Member

Like FunctionFlag

@larsrh
Copy link
Contributor Author

larsrh commented Sep 3, 2015

Okay, I can do that. Although it'll have only one subclass now, namely Annotation.

@larsrh
Copy link
Contributor Author

larsrh commented Sep 3, 2015

@manoskouk See now 19a6960.

Why do you need this?

Forgot to answer this: Function annotations can be used for declaring a mapping of Leon functions to Isabelle functions. For example, I can specify that List#map should be mapped to List.list.map in Isabelle. Class annotations can be used in the same way for declaring datatype mappings. With those, I specify that Leon's List ADT gets mapped to the List.list datatype.

@colder
Copy link
Member

colder commented Sep 7, 2015

Merged, thanks!

@colder colder closed this Sep 7, 2015
@larsrh larsrh deleted the topic/class-annotations branch September 7, 2015 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants