Skip to content

Commit

Permalink
complement filter: don't lower bound at 1 (that was arbitrary)
Browse files Browse the repository at this point in the history
  • Loading branch information
mdeff committed Dec 17, 2018
1 parent 99acfd8 commit 734dcd9
Showing 1 changed file with 3 additions and 4 deletions.
7 changes: 3 additions & 4 deletions pygsp/filters/filter.py
Expand Up @@ -610,9 +610,8 @@ def complement(self, frame_bound=None):
frame_bound : float or None
The desired frame bound :math:`A = B` of the resulting tight frame.
The chosen bound should be larger than the sum of squared
evaluations of all filters in the filter bank.
If None (the default), the method chooses the smallest feasible
bound that is greater than one.
evaluations of all filters in the filter bank. If None (the
default), the method chooses the smallest feasible bound.
Returns
-------
Expand Down Expand Up @@ -649,7 +648,7 @@ def kernel(x, *args, **kwargs):
y = np.sum(y, axis=0)

if frame_bound is None:
bound = np.maximum(np.max(y), 1)
bound = y.max()
elif y.max() > frame_bound:
raise ValueError('The chosen bound is not feasible. '
'Choose at least {}.'.format(y.max()))
Expand Down

0 comments on commit 734dcd9

Please sign in to comment.