Test tight #25
Merged
Test tight #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
closes: #19 |
add test updates fix bug fix bug fix lint
|
Thanks! Is that applicable to other functions than the l2 norm? |
|
I thought for the l1 norm as well... But eventually I think not. I am not entirely sure. It would take me quite a lot of math and testing to be sure. So I suggest to stop here. |
|
Sure. I'm not even convinced we should try to catch user errors. After all this library is made for users that want control. It is not a black-box optimization tool. |
mdeff
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Raise an error if a user define a weighed tight L2 norm function