Skip to content

Commit

Permalink
Removing 'coverage combine' in test script
Browse files Browse the repository at this point in the history
According to what was discovered in spack#6887, one of the problems is
calling 'coverage combine' twice without the '-a' flag. This removes
the first call within our test scripts.
  • Loading branch information
Test User committed Jan 16, 2018
1 parent f1a69a9 commit 22fb525
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 4 deletions.
1 change: 0 additions & 1 deletion share/spack/qa/run-build-tests
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,3 @@ spack config get compilers

# Run some build smoke tests, potentially with code coverage
${coverage_run} bin/spack install ${SPEC}
${coverage_combine}
1 change: 0 additions & 1 deletion share/spack/qa/run-unit-tests
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,3 @@ ${coverage_run} bin/spack -p --lines 20 spec mpileaks

# Run unit tests with code coverage
${coverage_run} bin/spack test "$@"
${coverage_combine}
2 changes: 0 additions & 2 deletions share/spack/qa/setup.sh
Original file line number Diff line number Diff line change
Expand Up @@ -14,11 +14,9 @@ SPACK_ROOT="$QA_DIR/../../.."
if [[ "$COVERAGE" == true ]]; then
coverage=coverage
coverage_run="coverage run"
coverage_combine="coverage combine"
else
coverage=""
coverage_run=""
coverage_combine=""
fi

#
Expand Down

0 comments on commit 22fb525

Please sign in to comment.