-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] GitHub Pages #24
base: main
Are you sure you want to change the base?
Conversation
5a0a7cf
to
f44c259
Compare
I though that ejs had a build process that could be used to generate a static website. It seems that the ejs CLI got something (https://stackoverflow.com/a/30978686/960623), but this is not really convenient. In the end, we have to ask ourself whether ejs was a good choice or not; if the templating language has to be changed, the sooner the better. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should remove (hide) the cookie consent banner.
In my opinion, the choice of template language has nothing to do with it. We can generate the templates as follows: ./node_modules/.bin/ejs ./src/views/pages/home.ejs -o index.html
./node_modules/.bin/ejs ./src/views/pages/catalog.ejs -i "{\"data\": `cat src/data/EPFL-services.json`}" -o catalog.html I see no point in maintaining a (complicated) build process to generate a static site in the medium-term. |
The `searchEngine` used to select the action for each search wasn't using a proper trim function, resulting in invalid match due to spaces.
* [feature] add "EPFL map" icon * [feature] add "EPFL people" icon * [feature] add "EPFL units" icon * [feature] add "actu" search * [feature] add EPNET search
This add a footer with link to - about page - the version (linked to GitHub release) - GitHub issue - help - source Update the catalog page with new footer. Closes #10
Yes, I will do it in a separate PR. |
Close #17
https://epfl-si.github.io/startpage