Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] GitHub Pages #24

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

[feature] GitHub Pages #24

wants to merge 11 commits into from

Conversation

obieler
Copy link
Member

@obieler obieler commented Nov 17, 2023 •
edited
Loading

@ponsfrilus
Copy link
Member

I though that ejs had a build process that could be used to generate a static website. It seems that the ejs CLI got something (https://stackoverflow.com/a/30978686/960623), but this is not really convenient. In the end, we have to ask ourself whether ejs was a good choice or not; if the templating language has to be changed, the sooner the better.

williambelle
williambelle reviewed Nov 21, 2023
View reviewed changes
Copy link
Member

@williambelle williambelle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should remove (hide) the cookie consent banner.

.github/workflows/githubpages.yml Outdated Show resolved Hide resolved
@williambelle
Copy link
Member

I though that ejs had a build process that could be used to generate a static website. It seems that the ejs CLI got something (stackoverflow.com/a/30978686/960623), but this is not really convenient. In the end, we have to ask ourself whether ejs was a good choice or not; if the templating language has to be changed, the sooner the better.

In my opinion, the choice of template language has nothing to do with it.

We can generate the templates as follows:

./node_modules/.bin/ejs ./src/views/pages/home.ejs -o index.html
./node_modules/.bin/ejs ./src/views/pages/catalog.ejs -i "{\"data\": `cat src/data/EPFL-services.json`}" -o catalog.html

I see no point in maintaining a (complicated) build process to generate a static site in the medium-term.
GitHub Pages should only be used for the short-term.

ponsfrilus and others added 6 commits January 9, 2024 14:36
@ponsfrilus @obieler
[fix] invisible chars in searchEngine variable (#25)
cce84a7 
The `searchEngine` used to select the action for each search wasn't
using a proper trim function, resulting in invalid match due to spaces.
@ponsfrilus @obieler
[feature] new search (#29)
00a032f 
* [feature] add "EPFL map" icon

* [feature] add "EPFL people" icon

* [feature] add "EPFL units" icon

* [feature] add "actu" search

* [feature] add EPNET search
@ponsfrilus @obieler
[feature] first changelog (#27)
4810cd5
@ponsfrilus @obieler
[feature] a minimalist footer (#26)
12bea2a 
This add a footer with link to
- about page
- the version (linked to GitHub release)
- GitHub issue
- help
- source

Update the catalog page with new footer.

Closes #10
@obieler
Update workflow title
e9c6148
@obieler
Missing word
5a0ca30
@obieler
Copy link
Member Author

obieler commented Jan 9, 2024

We should remove (hide) the cookie consent banner.

Yes, I will do it in a separate PR.

@obieler obieler added the enhancement New feature or request label Jan 9, 2024
@obieler obieler self-assigned this Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ponsfrilus ponsfrilus Awaiting requested review from ponsfrilus

@Azecko Azecko Awaiting requested review from Azecko

@williambelle williambelle Awaiting requested review from williambelle

Assignees

@obieler obieler

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature] GitHub pages
4 participants
@obieler @ponsfrilus @williambelle @Harpogma