Add get_os_pid/1 function
#270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seriyps
force-pushed
the
add-get_os_pid-function
branch
2 times, most recently
from
d1aaf6a
to
26ff983
Compare
seriyps
force-pushed
the
add-get_os_pid-function
branch
from
26ff983
to
e723d1a
Compare
jesperes
approved these changes
Mar 3, 2022
enidgjoleka
reviewed
Mar 4, 2022
src/epgsql.erl
Outdated
| %% | ||
| %% Similar to `SELECT pg_get_pid()', but does not need network roundtrips. | ||
| -spec get_os_pid(connection()) -> integer(). | ||
| get_os_pid(C) -> |
There was a problem hiding this comment.
I find it confusing the terminology around os since this call will be executed from a process within the BEAM that is potentially living in another machine compared to the PG server.
How about renaming it to pg_backend_pid?
There was a problem hiding this comment.
Good idea. I'd prefer get_backend_pid though, because epgsql is already about postgres. And in Postgres's SQL it's called pg_backend_pid to show that it is not from SQL standard, but Postgres vendor-specific I believe.
enidgjoleka
approved these changes
Mar 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's similar to
SELECT pg_backend_pid(), but does not need network roundtrip and can be called even when thefre is an asynchronous query is still running.