Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support blessed format_status/1 callback #277

Merged
merged 3 commits into from Dec 28, 2022

Conversation

keynslug
Copy link
Contributor

Add testcase on correctly redacted state.
Also mention that format_status/2 callback is deprecated since OTP-25.

@seriyps
Copy link
Member

seriyps commented Dec 23, 2022

Hi. In #276 the CI have been reworked a bit. May your PR wait for it to be merged and then rebased?

Add testcase on correctly redacted state.
Also mention that `format_status/2` callback is deprecated since OTP-25.
So that Github will complain no more about running on outdated
Node.js runtime.
@keynslug
Copy link
Contributor Author

Sure. Rebased it.

Copy link
Member

@seriyps seriyps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@seriyps seriyps requested a review from davidw December 27, 2022 09:31
@seriyps seriyps merged commit ebc262b into epgsql:devel Dec 28, 2022
@seriyps
Copy link
Member

seriyps commented Dec 28, 2022

Thanks @keynslug and @davidw !

@keynslug keynslug deleted the otp-25-compat branch December 28, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants